Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve layer mask handling #13065

Merged
merged 2 commits into from
Jul 3, 2021
Merged

Improve layer mask handling #13065

merged 2 commits into from
Jul 3, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Jun 1, 2021

Description

Add an explicit define for 32 bit layer mask, and set it as default.

Also, set default bitmask based on Dynamic Keymap layer count define to automatically handle this.

Types of Changes

  • Core
  • Enhancement/optimization

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested review from tzarc and a team June 1, 2021 06:20
@github-actions github-actions bot added the core label Jun 1, 2021
@drashna drashna force-pushed the core/layer_stuff branch from 86570f5 to 237f9c5 Compare June 1, 2021 06:22
@drashna drashna changed the base branch from master to develop June 1, 2021 06:25
@tzarc
Copy link
Member

tzarc commented Jun 1, 2021

Everything seems to still build, despite Travis having a bit of a bad day.

@fauxpark
Copy link
Member

fauxpark commented Jun 1, 2021

Not Travis, Docker.

@tzarc
Copy link
Member

tzarc commented Jun 1, 2021

It's Travis hitting up Docker too frequently... one of them is to blame, either way. Travis could use different IPs, do some caching, who knows.

@drashna
Copy link
Member Author

drashna commented Jun 1, 2021

It's Travis hitting up Docker too frequently... one of them is to blame, either way. Travis could use different IPs, do some caching, who knows.

We can also up the limit by including authentication, I believe. So .... there is that.

@drashna drashna force-pushed the core/layer_stuff branch from 237f9c5 to 7a0f5dd Compare July 3, 2021 07:06
@fauxpark fauxpark requested a review from a team July 3, 2021 07:07
@drashna drashna merged commit 8da8aab into qmk:develop Jul 3, 2021
@drashna drashna deleted the core/layer_stuff branch July 3, 2021 07:19
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants