Matrix consistency improvements #13471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
approved these changes
Jul 7, 2021
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
MMcM
added a commit
to MMcM/qmk_firmware
that referenced
this pull request
Feb 28, 2022
* Restore code from qmk#4483 to working order. * qmk#13471 changed MATRIX_ROW_PINS to avoid warnings, rather than realizing that it didn't mean the same thing. * qmk#13658 then removed it because it wouldn't compile after that. * So, instead rename the PIN macros to not conflict with regular matrix scanning.
MMcM
added a commit
to MMcM/qmk_firmware
that referenced
this pull request
May 29, 2022
* Restore code from qmk#4483 to working order. * qmk#13471 changed MATRIX_ROW_PINS to avoid warnings, rather than realizing that it didn't mean the same thing. * qmk#13658 then removed it because it wouldn't compile after that. * So, instead rename the PIN macros to not conflict with regular matrix scanning.
MMcM
added a commit
to MMcM/qmk_firmware
that referenced
this pull request
Oct 22, 2022
* Restore code from qmk#4483 to working order. * qmk#13471 changed MATRIX_ROW_PINS to avoid warnings, rather than realizing that it didn't mean the same thing. * qmk#13658 then removed it because it wouldn't compile after that. * So, instead rename the PIN macros to not conflict with regular matrix scanning.
MMcM
added a commit
to MMcM/qmk_firmware
that referenced
this pull request
Jan 31, 2025
* Restore code from qmk#4483 to working order. * qmk#13471 changed MATRIX_ROW_PINS to avoid warnings, rather than realizing that it didn't mean the same thing. * qmk#13658 then removed it because it wouldn't compile after that. * So, instead rename the PIN macros to not conflict with regular matrix scanning.
MMcM
added a commit
to MMcM/qmk_firmware
that referenced
this pull request
Feb 8, 2025
* Restore code from qmk#4483 to working order. * qmk#13471 changed MATRIX_ROW_PINS to avoid warnings, rather than realizing that it didn't mean the same thing. * qmk#13658 then removed it because it wouldn't compile after that. * So, instead rename the PIN macros to not conflict with regular matrix scanning.
MMcM
added a commit
to MMcM/qmk_firmware
that referenced
this pull request
Feb 22, 2025
* Restore code from qmk#4483 to working order. * qmk#13471 changed MATRIX_ROW_PINS to avoid warnings, rather than realizing that it didn't mean the same thing. * qmk#13658 then removed it because it wouldn't compile after that. * So, instead rename the PIN macros to not conflict with regular matrix scanning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on #13470 I noticed a lot of keyboards have
MATRIX_ROWSandMATRIX_COLSthat are inconsistent with the pins actually configured to be used. This PR attempts to correct that in most cases.TODO:
Types of Changes
Checklist