Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Fix compile issues for Knops Mini #13887

Closed
wants to merge 1 commit into from

Conversation

drashna
Copy link
Member

@drashna drashna commented Aug 4, 2021

Description

Fix some of the compilation issues with the board

Types of Changes

  • Bugfix
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna added the bug label Aug 4, 2021
@github-actions github-actions bot added the keymap label Aug 4, 2021
@drashna drashna requested a review from a team August 4, 2021 18:52
@daskygit
Copy link
Member

daskygit commented Aug 4, 2021

Fixed in #13872

@drashna
Copy link
Member Author

drashna commented Aug 4, 2021

hah, I checked real quick but apparently missed it. Thanks!

@drashna drashna closed this Aug 4, 2021
@drashna drashna deleted the fix/keyboard_knops_mini branch August 4, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants