Westberrytech pr #14422

itarze · 2021-09-13T09:52:53Z

Description

Added WB32F3G71xx support

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna · 2021-09-14T00:02:06Z

This needs to be split up into several PRs. At the very least, the keyboard code needs to be pulled out into a separate PR, so this is just adding the platform files for the WB32 controller.

itarze · 2021-09-14T01:17:42Z

@drashna I have deleted the keyboard code , Wait for this pr to pass before submitting the keyboard code.

bootloader.mk

platforms/chibios/drivers/i2c_master.c

platforms/chibios/flash.mk

itarze · 2021-10-27T02:55:40Z

@fauxpark Hi, can you through this PR?

itarze

pass

drashna · 2021-11-11T05:02:09Z

should be fine to ignore this specific error, IIRC.

itarze · 2021-11-11T05:11:53Z

@drashna May I ask when this PR can be merged or is there anything else that needs to be fixed? Our company is in a hurry.

drashna · 2021-11-11T05:18:17Z

It's waiting on another approval, as we generally only merge PRs after 2 approvals, especially for core changes.

However, the hope is that this gets into this breaking changes cycle, so that it's merged into master, at the end of the month.

itarze · 2021-11-11T05:25:26Z

@drashna Can you help me to urge the another approver? He never replied to me. Please

platforms/chibios/drivers/uart.c

platforms/chibios/drivers/spi_master.c

platforms/chibios/drivers/i2c_master.c

lib/python/qmk/cli/doctor/linux.py

platforms/chibios/drivers/spi_master.c

tmk_core/common/chibios/bootloader.c

tmk_core/common/chibios/eeprom_wb32.c

itarze

WB32 flash has 200k+ write cycle endurance.
I have modified the code, please check whether there are other problems.

zvecr · 2021-11-18T12:32:20Z

tmk_core/common/chibios/eeprom_wb32.c

+
+    WriteLen = (Len < PageReamin) ? Len : PageReamin;
+
+    if (WriteLen != FEE_PAGE_SIZE) {


If a byte is already written,

The function docs still does not match the behaviour. All that has been added is an optimisation when writes align to page size, along with a load of duplication and a dead return path.

tmk_core/common/chibios/eeprom_wb32.c

itarze · 2021-11-19T01:38:30Z

I'll remove the code related to the eeprom_wb32 first.
Our customers can use external eeprom to store data.

peepeetee · 2021-11-19T01:56:56Z

Is there any language help I can offer here? I could be reached at [email protected]
在？我来帮您说英语？在[email protected]联系我

drashna · 2021-11-19T19:06:14Z

This has some merge conflicts that need to be resolved.

itarze · 2021-11-19T20:34:54Z

This has some merge conflicts that need to be resolved.

I have solved it, please review it again.

itarze · 2021-11-19T20:54:28Z

Is it ok to pass now?
Two reviewers have been approved.

tzarc · 2021-11-19T21:05:14Z

Is it ok to pass now? Two reviewers have been approved.

There's only one green tick.

defer to experts

tzarc · 2021-11-19T21:13:48Z

That was old and has since been rescinded.

itarze · 2021-11-19T21:17:34Z

Okay, so now I just need to wait other reviewer approval ？

tzarc · 2021-11-19T21:17:50Z

Yes.

itarze · 2021-11-19T21:18:49Z

Thanks ！

github-actions bot added cli qmk cli command core documentation keyboard keymap python labels Sep 13, 2021

drashna requested a review from a team September 13, 2021 20:16

itarze force-pushed the westberrytech_pr branch from c97a01f to bcdea7d Compare September 14, 2021 01:13

github-actions bot removed keymap keyboard labels Sep 14, 2021

drashna requested changes Sep 14, 2021

View reviewed changes

bootloader.mk Outdated Show resolved Hide resolved

platforms/chibios/drivers/i2c_master.c Outdated Show resolved Hide resolved

platforms/chibios/flash.mk Outdated Show resolved Hide resolved

itarze requested review from drashna and fauxpark October 18, 2021 05:55

drashna previously approved these changes Oct 23, 2021

View reviewed changes

drashna requested a review from a team October 23, 2021 06:23

itarze commented Nov 1, 2021

View reviewed changes

tzarc added the breaking_change_2021q4 label Nov 1, 2021

github-actions bot added the dependencies label Nov 9, 2021

itarze force-pushed the westberrytech_pr branch from 6e431a8 to 12eec73 Compare November 9, 2021 01:08

github-actions bot removed the dependencies label Nov 9, 2021

drashna requested a review from tzarc November 10, 2021 15:19

zvecr requested changes Nov 13, 2021

View reviewed changes

platforms/chibios/drivers/uart.c Outdated Show resolved Hide resolved

platforms/chibios/drivers/spi_master.c Outdated Show resolved Hide resolved

platforms/chibios/drivers/i2c_master.c Outdated Show resolved Hide resolved

zvecr requested changes Nov 13, 2021

View reviewed changes

lib/python/qmk/cli/doctor/linux.py Outdated Show resolved Hide resolved

platforms/chibios/drivers/spi_master.c Outdated Show resolved Hide resolved

tmk_core/common/chibios/bootloader.c Outdated Show resolved Hide resolved

tmk_core/common/chibios/eeprom_wb32.c Outdated Show resolved Hide resolved

itarze commented Nov 18, 2021

View reviewed changes

zvecr reviewed Nov 18, 2021

View reviewed changes

tzarc reviewed Nov 18, 2021

View reviewed changes

tmk_core/common/chibios/eeprom_wb32.c Outdated Show resolved Hide resolved

Modified eeprom_wb32.c

b65997c

itarze force-pushed the westberrytech_pr branch from ee466f7 to b65997c Compare November 19, 2021 00:55

Remove the eeprom_wb32-related code

670ebac

itarze requested review from tzarc and zvecr November 19, 2021 01:47

drashna self-requested a review November 19, 2021 06:11

Merge branch 'develop' into westberrytech_pr

752e0aa

tzarc approved these changes Nov 19, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

zvecr approved these changes Nov 26, 2021

View reviewed changes

tzarc merged commit 68838bb into qmk:develop Nov 26, 2021

itarze deleted the westberrytech_pr branch December 3, 2021 05:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Westberrytech pr #14422

Westberrytech pr #14422

itarze commented Sep 13, 2021 •

edited

Loading

drashna commented Sep 14, 2021

itarze commented Sep 14, 2021

itarze commented Oct 27, 2021

itarze left a comment

drashna commented Nov 11, 2021

itarze commented Nov 11, 2021

drashna commented Nov 11, 2021

itarze commented Nov 11, 2021

itarze left a comment

zvecr Nov 18, 2021 •

edited

Loading

itarze commented Nov 19, 2021

peepeetee commented Nov 19, 2021

drashna commented Nov 19, 2021

itarze commented Nov 19, 2021

itarze commented Nov 19, 2021

tzarc commented Nov 19, 2021 •

edited

Loading

This comment has been minimized.

tzarc commented Nov 19, 2021

itarze commented Nov 19, 2021

tzarc commented Nov 19, 2021

itarze commented Nov 19, 2021


		WriteLen = (Len < PageReamin) ? Len : PageReamin;

		if (WriteLen != FEE_PAGE_SIZE) {

Westberrytech pr #14422

Westberrytech pr #14422

Conversation

itarze commented Sep 13, 2021 • edited Loading

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

drashna commented Sep 14, 2021

itarze commented Sep 14, 2021

itarze commented Oct 27, 2021

itarze left a comment

Choose a reason for hiding this comment

drashna commented Nov 11, 2021

itarze commented Nov 11, 2021

drashna commented Nov 11, 2021

itarze commented Nov 11, 2021

itarze left a comment

Choose a reason for hiding this comment

zvecr Nov 18, 2021 • edited Loading

Choose a reason for hiding this comment

itarze commented Nov 19, 2021

peepeetee commented Nov 19, 2021

drashna commented Nov 19, 2021

itarze commented Nov 19, 2021

itarze commented Nov 19, 2021

tzarc commented Nov 19, 2021 • edited Loading

This comment has been minimized.

tzarc commented Nov 19, 2021

itarze commented Nov 19, 2021

tzarc commented Nov 19, 2021

itarze commented Nov 19, 2021

itarze commented Sep 13, 2021 •

edited

Loading

zvecr Nov 18, 2021 •

edited

Loading

tzarc commented Nov 19, 2021 •

edited

Loading