-
-
Notifications
You must be signed in to change notification settings - Fork 40.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dactyl Manuform 4x5 with 5 thumb cluster #17671
Merged
keyboard-magpie
merged 12 commits into
qmk:master
from
Southporter:4x5_5-dactyl-manuform
Aug 13, 2022
Merged
Dactyl Manuform 4x5 with 5 thumb cluster #17671
keyboard-magpie
merged 12 commits into
qmk:master
from
Southporter:4x5_5-dactyl-manuform
Aug 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested changes
Jul 14, 2022
keyboards/handwired/dactyl_manuform/4x5_5/keymaps/default/config.h
Outdated
Show resolved
Hide resolved
keyboards/handwired/dactyl_manuform/4x5_5/keymaps/default/keymap.c
Outdated
Show resolved
Hide resolved
keyboards/handwired/dactyl_manuform/4x5_5/keymaps/default/keymap.c
Outdated
Show resolved
Hide resolved
keyboards/handwired/dactyl_manuform/4x5_5/keymaps/ssedrick/config.h
Outdated
Show resolved
Hide resolved
keyboards/handwired/dactyl_manuform/4x5_5/keymaps/ssedrick/keymap.c
Outdated
Show resolved
Hide resolved
keyboards/handwired/dactyl_manuform/4x5_5/keymaps/ssedrick/keymap.c
Outdated
Show resolved
Hide resolved
936a2a9
to
97fd2b2
Compare
The pro-micro was not working when I plugged into the elite-c on the right hand side of my keyboard. Adding the SPLIT_USB_DIRECT definition fixed the issue.
Adding Drashna's delete comments Co-authored-by: Drashna Jaelre <[email protected]>
Per Drashna's pr review, I have removed the config.h files for the keymaps. Also tweaked my keymap to switch backspace and enter. Added tapping toggle for RAISE.
As with most new keyboards, they take some getting used to. I've rearranged my thumb cluster to hopfully a more long term solution.
0a555ed
to
c4dde35
Compare
drashna
approved these changes
Jul 26, 2022
keyboard-magpie
approved these changes
Aug 13, 2022
imhoffman
pushed a commit
to imhoffman/qmk_firmware
that referenced
this pull request
Aug 20, 2022
* Working on new dactyl * Preliminary build and keymap in place for 4x5_5 dactyl manuform * Removing first attempt to use 4x5 * Updating to match c style guide * Fixing issues after merge, deletion of dactyl_manuform.h * Spliting out custom keymap * Adding license headers * Fixing EE_HANDS detection on Pro-Micro The pro-micro was not working when I plugged into the elite-c on the right hand side of my keyboard. Adding the SPLIT_USB_DIRECT definition fixed the issue. * Apply suggestions from code review Adding Drashna's delete comments Co-authored-by: Drashna Jaelre <[email protected]> * Removed config.h for keymaps and tweaked keymap Per Drashna's pr review, I have removed the config.h files for the keymaps. Also tweaked my keymap to switch backspace and enter. Added tapping toggle for RAISE. * Further tweaking ssedrick keymap for dactyl_manuform 4x5_5 As with most new keyboards, they take some getting used to. I've rearranged my thumb cluster to hopfully a more long term solution. * Adding missing KC_BSLS to ssedrick keymap for 4x5_5 Co-authored-by: Drashna Jaelre <[email protected]>
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
* Working on new dactyl * Preliminary build and keymap in place for 4x5_5 dactyl manuform * Removing first attempt to use 4x5 * Updating to match c style guide * Fixing issues after merge, deletion of dactyl_manuform.h * Spliting out custom keymap * Adding license headers * Fixing EE_HANDS detection on Pro-Micro The pro-micro was not working when I plugged into the elite-c on the right hand side of my keyboard. Adding the SPLIT_USB_DIRECT definition fixed the issue. * Apply suggestions from code review Adding Drashna's delete comments Co-authored-by: Drashna Jaelre <[email protected]> * Removed config.h for keymaps and tweaked keymap Per Drashna's pr review, I have removed the config.h files for the keymaps. Also tweaked my keymap to switch backspace and enter. Added tapping toggle for RAISE. * Further tweaking ssedrick keymap for dactyl_manuform 4x5_5 As with most new keyboards, they take some getting used to. I've rearranged my thumb cluster to hopfully a more long term solution. * Adding missing KC_BSLS to ssedrick keymap for 4x5_5 Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new version of the dactyl manuform. The 4x5 uses 6 keys in the thumb cluster, so needed a new one that supports only a 5 key thumb cluster
Description
Types of Changes
Checklist