Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uupdate Fave104 keymap #18004

Merged
merged 1 commit into from
Aug 13, 2022
Merged

Uupdate Fave104 keymap #18004

merged 1 commit into from
Aug 13, 2022

Conversation

duilchoi
Copy link
Contributor

fixed keymaps.

Description

Fix keymap matching error in file (keymap.c)

/keymaps/default/keymap.c ---> change KC_NUM_LOCK to KC_NUM.
/keymaps/via/keymap.c ---> change KC_NUM_LOCK to KC_NUM.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 12, 2022
@github-actions github-actions bot removed the keyboard label Aug 12, 2022
@zvecr zvecr requested a review from a team August 12, 2022 15:38
@drashna drashna merged commit a1fe9fe into qmk:master Aug 13, 2022
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@duilchoi @imhoffman
[Keymap] update fave104 keymap (qmk#18004)
2e1570d
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@duilchoi @nolanseaton
[Keymap] update fave104 keymap (qmk#18004)
b2a2d17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@duilchoi @fauxpark @zvecr @drashna