Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Increase kinesis/kint41 unselect delay #18015

Merged
merged 2 commits into from
Aug 13, 2022

Conversation

rockybulwinkle
Copy link

Fixes #18014
@drashna @stapelberg

Description

I increased the matrix_output_unselect_delay time to resolve a ghosting problem I was having, described in #18014

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

I have only tested the build of my keyboard's firmware. The change seems exceedingly unlikely to break other firmwares.

Use correct si-abbreviation for micro in comment.
@drashna drashna requested a review from a team August 13, 2022 02:28
@zvecr zvecr merged commit fb150e0 into qmk:master Aug 13, 2022
@rockybulwinkle rockybulwinkle deleted the fix-18014 branch August 13, 2022 02:46
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
* [Keyboard] Increase kinesis/kint41 unselect delay

Fixes qmk#18014

* Update kint41.c

Use correct si-abbreviation for micro in comment.
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
* [Keyboard] Increase kinesis/kint41 unselect delay

Fixes qmk#18014

* Update kint41.c

Use correct si-abbreviation for micro in comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] kinesis w/ stapelberg ghosting on certain keys
3 participants