Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add personal keymap for kprepublic BM40HSRGB #18021

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Add personal keymap for kprepublic BM40HSRGB #18021

merged 3 commits into from
Aug 17, 2022

Conversation

CoffeeIsLife87
Copy link
Contributor

Description

This is the keymap I've been using for months at this point and I think it flows well and is easy to adjust to after coming from a larger sized board ( I was using a TKL before this )

The primary layer is a qwerty layer
The FN/Num/Nav layer is activated with the key to the immediate left of the spacebar
The RGB/Volume/Macro layer is activated with the key to the immediate right of the spacebar

This PR was initially #17794 but too many things were done wrong that it was easier to redo it here
I've gone over everything a few times now and I think it's good

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team August 13, 2022 17:32
@drashna drashna merged commit 0df97fc into qmk:master Aug 17, 2022
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants