MIIIW BlackIO98 & BlackIO83

[miiiw]

Add new keyboards BlackIO98 & BlackIO83, this is the first commit to QMK respository of MIIIW.

Description

• Add keyboard BlackIO98, an ansi version of 98 keys keyboard.
• Add keyboard BlackIO83, an ansi version of 83 keys keyboard.

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[miiiw]

Fixed all changes metioned by zvecr.

[miiiw]

Done, finished all changes.

[miiiw]

Changed according to suggestion.

[miiiw]

Dear Jouke, We have fixed these codes and commited, pls review. Thanks! Johnny 2022-10-11      ------------------ Original ------------------ From: ***@***.***>; Date:  Sun, Oct 9, 2022 11:31 PM To: ***@***.***>; Cc: ***@***.***>; ***@***.***>; Subject:  Re: [qmk/qmk_firmware] MIIIW BlackIO98 & BlackIO83 (PR #18343)   @joukewitteveen commented on this pull request. In keyboards/miiiw/blackio83/blackio83.c: > + loop10hz_token = defer_exec(LOOP_10HZ_PERIOD, loop_10Hz, NULL); +} + +bool led_update_kb(led_t led_state) { + writePinLow(MWPROTO_WAKEUP_PIN); + if(readPin(MWPROTO_STATUS_PIN)) + wait_us(500); + else + wait_us(1500); + sdPutI(&MWPROTO_DRIVER, 0xA5); + sdPutI(&MWPROTO_DRIVER, 0x61); + sdPutI(&MWPROTO_DRIVER, 0x01); + sdPutI(&MWPROTO_DRIVER, led_state.raw); + sdPutI(&MWPROTO_DRIVER, 0xC5 ^ led_state.raw); + writePinHigh(MWPROTO_WAKEUP_PIN); + return false; // prevent keyboard from processing state Normally, the return value of led_update_kb is not checked (quantum/led.c:led_set). What I believe you really want here, after #14452, is a function void led_update_ports. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

[miiiw]

Dear Drashna, We have fixed these codes and commited, pls review. Thanks! Johnny 2022-10-11 &nbsp; &nbsp; ------------------&nbsp;Original&nbsp;------------------ From: ***@***.***&gt;; Date: &nbsp;Mon, Oct 10, 2022 03:27 PM To: ***@***.***&gt;; Cc: ***@***.***&gt;; ***@***.***&gt;; Subject: &nbsp;Re: [qmk/qmk_firmware] MIIIW BlackIO98 &amp; BlackIO83 (PR #18343) &nbsp; @drashna requested changes on this pull request. In keyboards/miiiw/blackio83/keymaps/default/keymap.c: &gt; +// Implement Super-alt↯tab +// See https://docs.qmk.fm/#/feature_macros?id=super-alt↯tab +static bool is_alt_tab_active = false; +static uint32_t alt_tab_timer = 0; + +#ifdef DIP_SWITCH_ENABLE +bool dip_switch_update_user(uint8_t index, bool active) { + switch (index) { + case 2: + default_layer_set(1UL << (active ? WIN_BL : MAC_BL)); + break; + } + return true; +} +#endif + +// Processing all the key pressed. +// Alt+tab. +bool process_record_user(uint16_t keycode, keyrecord_t *record) { + uint8_t shift_mods = get_mods() &amp; MOD_MASK_SHIFT; + switch (keycode) { // This will do most of the grunt work with the keycodes. + case ALT_TAB: + if (record-&gt;event.pressed) { + if (!is_alt_tab_active) { + is_alt_tab_active = true; + register_code(KC_LALT); + } + alt_tab_timer = timer_read32(); + register_code(KC_TAB); + } else { + unregister_code(KC_TAB); + } + return false; + case RGB_RST: + if (record-&gt;event.pressed) { + eeconfig_update_rgb_matrix_default(); + } + return false; + case RGB_VAI: + if(shift_mods) { + if (record-&gt;event.pressed) rgb_matrix_increase_speed(); + return false; + } + break; + case RGB_VAD: + if(shift_mods) { + if (record-&gt;event.pressed &amp;&amp; rgb_matrix_get_speed() &gt;= RGB_MATRIX_SPD_STEP) rgb_matrix_decrease_speed(); + return false; + } + break; + case RGB_MOD: + if(shift_mods) { + if (record-&gt;event.pressed) rgb_matrix_increase_hue(); + return false; + } + break; + case RGB_RMOD: + if(shift_mods) { + if (record-&gt;event.pressed) rgb_matrix_decrease_hue(); + return false; + } + break; + } + + return true; +} + +void matrix_scan_user(void) { // The very important timer. + if (is_alt_tab_active &amp;&amp; timer_elapsed32(alt_tab_timer) &gt; 750) { + unregister_code(KC_LALT); + is_alt_tab_active = false; + } +} Could you please remove this. We want the default keymaps to be as plain and simple as possible, as this is what is cloned when qmk new-keymap is ran. Additionally, it looks like a lot of the added keycodes don't actually replace functionality. And it is fine to have a "stock" keymap with additional functionality. ️ Suggested change -// Implement Super-alt↯tab -// See https://docs.qmk.fm/#/feature_macros?id=super-alt↯tab -static bool is_alt_tab_active = false; -static uint32_t alt_tab_timer = 0; - -#ifdef DIP_SWITCH_ENABLE -bool dip_switch_update_user(uint8_t index, bool active) { - switch (index) { - case 2: - default_layer_set(1UL << (active ? WIN_BL : MAC_BL)); - break; - } - return true; -} -#endif - -// Processing all the key pressed. -// Alt+tab. -bool process_record_user(uint16_t keycode, keyrecord_t *record) { - uint8_t shift_mods = get_mods() &amp; MOD_MASK_SHIFT; - switch (keycode) { // This will do most of the grunt work with the keycodes. - case ALT_TAB: - if (record-&gt;event.pressed) { - if (!is_alt_tab_active) { - is_alt_tab_active = true; - register_code(KC_LALT); - } - alt_tab_timer = timer_read32(); - register_code(KC_TAB); - } else { - unregister_code(KC_TAB); - } - return false; - case RGB_RST: - if (record-&gt;event.pressed) { - eeconfig_update_rgb_matrix_default(); - } - return false; - case RGB_VAI: - if(shift_mods) { - if (record-&gt;event.pressed) rgb_matrix_increase_speed(); - return false; - } - break; - case RGB_VAD: - if(shift_mods) { - if (record-&gt;event.pressed &amp;&amp; rgb_matrix_get_speed() &gt;= RGB_MATRIX_SPD_STEP) rgb_matrix_decrease_speed(); - return false; - } - break; - case RGB_MOD: - if(shift_mods) { - if (record-&gt;event.pressed) rgb_matrix_increase_hue(); - return false; - } - break; - case RGB_RMOD: - if(shift_mods) { - if (record-&gt;event.pressed) rgb_matrix_decrease_hue(); - return false; - } - break; - } - - return true; -} - -void matrix_scan_user(void) { // The very important timer. - if (is_alt_tab_active &amp;&amp; timer_elapsed32(alt_tab_timer) &gt; 750) { - unregister_code(KC_LALT); - is_alt_tab_active = false; - } -} In keyboards/miiiw/blackio83/keymaps/via/keymap.c: &gt; + KC_LCTL, KC_LALT, KC_LGUI, KC_SPC, KC_RGUI, MO(MAC_FL), KC_RALT, KC_LEFT, KC_DOWN, KC_RGHT + ), + + /* Keymap MAC_FL: Mac Function Layer + */ + [MAC_FL] = LAYOUT( + RGB_RST, KC_F1, KC_F2, KC_F3, KC_F4, KC_F5, KC_F6, KC_F7, KC_F8, KC_F9, KC_F10, KC_F11, KC_F12, _______, KC_PSCR, + _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, KC_DEL, _______, + _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, QK_BOOT, _______, + _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, + _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, RGB_VAI, _______, + _______, _______, _______, _______, _______, _______, _______, RGB_RMOD, RGB_VAD, RGB_MOD + ), +}; + +// Implement Super-alt↯tab same. In keyboards/miiiw/blackio83/readme.md: &gt; + + ️ Suggested change - - + + In keyboards/miiiw/blackio98/keymaps/default/keymap.c: &gt; + KC_LCTL, KC_LALT, KC_LGUI, KC_SPC, KC_RGUI, MO(MAC_FL), KC_RALT, KC_LEFT, KC_DOWN, KC_RGHT, KC_P0, KC_PDOT, KC_PENT + ), + + /* Keymap MAC_FL: Mac Function Layer + */ + [MAC_FL] = LAYOUT( + RGB_RST, KC_F1, KC_F2, KC_F3, KC_F4, KC_F5, KC_F6, KC_F7, KC_F8, KC_F9, KC_F10, KC_F11, KC_F12, _______, KC_PSCR, KC_HOME, KC_END, + _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, KC_DEL, _______, _______, _______, _______, + _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, + _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, + _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, RGB_VAI, _______, _______, _______, + _______, _______, _______, _______, _______, _______, _______, RGB_RMOD, RGB_VAD, RGB_MOD, _______, _______, _______ + ), +}; + +// Implement Super-alt↯tab same In keyboards/miiiw/blackio98/keymaps/via/keymap.c: &gt; + KC_LCTL, KC_LALT, KC_LGUI, KC_SPC, KC_RGUI, MO(MAC_FL), KC_RALT, KC_LEFT, KC_DOWN, KC_RGHT, KC_P0, KC_PDOT, KC_PENT + ), + + /* Keymap MAC_FL: Mac Function Layer + */ + [MAC_FL] = LAYOUT( + RGB_RST, KC_F1, KC_F2, KC_F3, KC_F4, KC_F5, KC_F6, KC_F7, KC_F8, KC_F9, KC_F10, KC_F11, KC_F12, _______, KC_PSCR, KC_HOME, KC_END, + _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, KC_DEL, _______, _______, _______, _______, + _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, + _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, + _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, RGB_VAI, _______, _______, _______, + _______, _______, _______, _______, _______, _______, _______, RGB_RMOD, RGB_VAD, RGB_MOD, _______, _______, _______ + ), +}; + +// Implement Super-alt↯tab same — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***&gt;

[github-actions]

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

[github-actions]

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

[github-actions]

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]