Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix boardsource/lulu RGB matrix #18407

Merged
merged 3 commits into from
Sep 19, 2022
Merged

Fix boardsource/lulu RGB matrix #18407

merged 3 commits into from
Sep 19, 2022

Conversation

jumper149
Copy link
Contributor

@jumper149 jumper149 commented Sep 18, 2022 •
edited by zvecr
Loading

I stumbled upon issue #18401.

Now the RGB matrix is in the correct order.
I fixed some other small details in separate commits.

The linked issue shows some pictures of the working firmware.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • (doesn't apply) My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • (doesn't apply) I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@jumper149
Fix ordering of entries for RGB matrix.
f2ce4e3
@jumper149
Fix typos in RGB matrix definition.
5e7962b 
These matrix indices overlapped.
@jumper149
Improve positions in RGB matrix.
e63f40a 
The rotary encoder and the key below that are in a new column.
The rotary encoder's height is inbetween rows.
The key below is kind of off-axis and thus hard to pin down to a
specific location.

The modifer keys in the bottom row are staggered compared to the other
columns.
@jumper149
Copy link
Contributor Author

Are the commit messages fine the way they are?

daskygit
daskygit approved these changes Sep 18, 2022
View reviewed changes
Copy link
Member

@daskygit daskygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @waffle87 you able to test this or are you happy with the edits?

@waffle87
Copy link
Member

waffle87 commented Sep 19, 2022 •
edited
Loading

Tested on hardware — lgtm. Thanks for the fix :)

@zvecr zvecr merged commit 51620c1 into qmk:master Sep 19, 2022
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 2, 2022
@jumper149 @tacahiroy
Fix boardsource/lulu RGB matrix (qmk#18407)
eeb8dcc 
* Fix ordering of entries for RGB matrix.

* Fix typos in RGB matrix definition.

These matrix indices overlapped.

* Improve positions in RGB matrix.

The rotary encoder and the key below that are in a new column.
The rotary encoder's height is inbetween rows.
The key below is kind of off-axis and thus hard to pin down to a
specific location.

The modifer keys in the bottom row are staggered compared to the other
columns.
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@jumper149
Fix boardsource/lulu RGB matrix (qmk#18407)
3841cb5 
* Fix ordering of entries for RGB matrix.

* Fix typos in RGB matrix definition.

These matrix indices overlapped.

* Improve positions in RGB matrix.

The rotary encoder and the key below that are in a new column.
The rotary encoder's height is inbetween rows.
The key below is kind of off-axis and thus hard to pin down to a
specific location.

The modifer keys in the bottom row are staggered compared to the other
columns.
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@jumper149 @ramonimbao
Fix boardsource/lulu RGB matrix (qmk#18407)
4c4cd8a 
* Fix ordering of entries for RGB matrix.

* Fix typos in RGB matrix definition.

These matrix indices overlapped.

* Improve positions in RGB matrix.

The rotary encoder and the key below that are in a new column.
The rotary encoder's height is inbetween rows.
The key below is kind of off-axis and thus hard to pin down to a
specific location.

The modifer keys in the bottom row are staggered compared to the other
columns.
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@jumper149 @nolanseaton
Fix boardsource/lulu RGB matrix (qmk#18407)
30c6d7a 
* Fix ordering of entries for RGB matrix.

* Fix typos in RGB matrix definition.

These matrix indices overlapped.

* Improve positions in RGB matrix.

The rotary encoder and the key below that are in a new column.
The rotary encoder's height is inbetween rows.
The key below is kind of off-axis and thus hard to pin down to a
specific location.

The modifer keys in the bottom row are staggered compared to the other
columns.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@daskygit daskygit daskygit approved these changes

@waffle87 waffle87 waffle87 approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Boardsource: Lulu: RP2040: RGB_ALPHAS_MODS appears to be configured wrong
4 participants
@jumper149 @waffle87 @zvecr @daskygit