Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Star75 Refactor #18885

Merged
merged 5 commits into from
Oct 31, 2022
Merged

Star75 Refactor #18885

merged 5 commits into from
Oct 31, 2022

Conversation

noroadsleft
Copy link
Member

Description

  • rename LAYOUT_all to LAYOUT (only one layout supported)
  • star75.h: use XXX for KC_NO; convert tabs to spaces; add matrix diagram
  • info.json: apply friendly formatting

cc @hornslyn (keyboard maintainer, sort of)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 27, 2022
@noroadsleft noroadsleft requested a review from a team October 27, 2022 17:23
@drashna drashna requested a review from a team October 31, 2022 02:22
@drashna drashna merged commit 1183704 into qmk:master Oct 31, 2022
@noroadsleft noroadsleft deleted the rf/star75 branch November 2, 2022 22:31
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@noroadsleft
Star75 Refactor (qmk#18885)
65613b5
thystips pushed a commit to thystips/qmk_firmware that referenced this pull request Nov 24, 2022
@noroadsleft @thystips
Star75 Refactor (qmk#18885)
612390a
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@noroadsleft @ramonimbao
Star75 Refactor (qmk#18885)
aa17ff6
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@noroadsleft @elpekenin
Star75 Refactor (qmk#18885)
e912c22
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@noroadsleft @nolanseaton
Star75 Refactor (qmk#18885)
d21a21b
ChrisChrisLoLo pushed a commit to ChrisChrisLoLo/qmk_firmware that referenced this pull request Sep 2, 2023
@noroadsleft @ChrisChrisLoLo
Star75 Refactor (qmk#18885)
53d2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @drashna @fauxpark