Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Joystick feature improvements #19052

Merged
merged 16 commits into from
Nov 26, 2022
Merged

Joystick feature improvements #19052

merged 16 commits into from
Nov 26, 2022

Conversation

fauxpark
Copy link
Member

Description

Somewhat of a sister PR to #19034.

  • Improved documentation, added API reference
  • Renamed JOYSTICK_AXES_COUNT/JOYSTICK_AXES_RESOLUTION to singular AXIS to align with JOYSTICK_BUTTON_COUNT
  • Replaced enum joystick_status with simple dirty flag in joystick_t
  • Added V-USB support
  • Added shared EP support for LUFA/ChibiOS

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team November 13, 2022 08:46
@fauxpark fauxpark marked this pull request as ready for review November 25, 2022 07:55
@tzarc tzarc merged commit 1e95f7b into qmk:develop Nov 26, 2022
@fauxpark fauxpark deleted the joystick-improvements branch November 26, 2022 16:30
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @ramonimbao
Joystick feature improvements (qmk#19052)
fdd016a
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@fauxpark @elpekenin
Joystick feature improvements (qmk#19052)
3a1a9a2
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@fauxpark @crembz
Joystick feature improvements (qmk#19052)
ed5f9ac
@sigprof sigprof mentioned this pull request Jan 15, 2023
Merged
14 tasks
sigprof added a commit to sigprof/qmk_firmware that referenced this pull request Jan 16, 2023
@sigprof
Fix JOYSTICK_AXIS_COUNT name in docs
0aeed85 
In qmk#19052 the define was renamed from `JOYSTICK_AXES_COUNT` to
`JOYSTICK_AXIS_COUNT`, but some usages of the old name in docs were
missed.
@sigprof sigprof mentioned this pull request Jan 16, 2023
Merged
14 tasks
@9R 9R mentioned this pull request Mar 1, 2023
Closed
4 tasks
ohlin added a commit to ohlin/qmk_firmware that referenced this pull request May 25, 2023
@ohlin
Merge branch 'ko-kyria' of https://github.com/ohlin/qmk_firmware into…
3f8518a 
… ko-kyria

* 'ko-kyria' of https://github.com/ohlin/qmk_firmware: (603 commits)
  Fix Czech sendstring LUT (qmk#19193)
  fix typo (qmk#19189)
  new keyboard rb1 (qmk#18164)
  Fix RWIN typo within keycode list (qmk#19155)
  [Docs] Update reference_info_json.md (qmk#18817)
  Add piantor (qmk#18920)
  2022 Nov 26 changelog. (qmk#19164)
  Fix API errors in handwired/tractyl_manuform/5x6_right/arduinomicro (qmk#19166)
  Revert lib/usbhost changes (qmk#19165)
  Fix encoder_init call order in keyboard_init (qmk#19140)
  Change `RGB_MATRIX_STARTUP_*` defines to `RGB_MATRIX_DEFAULT_*` (qmk#19079)
  Fixup installation procedure for different Fedora versions. (qmk#19159)
  Joystick feature improvements (qmk#19052)
  Change `LED_MATRIX_STARTUP_*` defines to `LED_MATRIX_DEFAULT_*` (qmk#19080)
  Fix build failures for `bastardkb/tbk` and `jels/boaty` (qmk#19152)
  Fix annepro2/c18:iso_default (qmk#19147)
  jsonify some info.json (qmk#19146)
  Fixup aurora/corne on develop (qmk#19144)
  Additional DD backlight config (qmk#19124)
  [Keymap] komidore64 planck rev6 (qmk#19036)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core documentation enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @tzarc