Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom keycodes in JSON #19925

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Custom keycodes in JSON #19925

merged 2 commits into from
Mar 27, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 23, 2023 •
edited
Loading

Description

Resurrection of 14363.

Add support for keycodes in info.json and keymap.json.

This will eventually allow configurators to display more context than just QK_KB QK_USER.

Future TODO:

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr force-pushed the feature/json_keycodes branch 2 times, most recently from 13548af to 3a8e8fc Compare March 1, 2023 01:29
@zvecr zvecr force-pushed the feature/json_keycodes branch 2 times, most recently from 4274009 to 2731667 Compare March 8, 2023 10:25
@drashna drashna requested a review from a team March 10, 2023 19:50
@zvecr zvecr force-pushed the feature/json_keycodes branch from d6d25f1 to 01d4cb9 Compare March 27, 2023 19:00
@zvecr zvecr merged commit 79b0f91 into qmk:develop Mar 27, 2023
nicsuzor pushed a commit to nicsuzor/qmk_firmware that referenced this pull request Mar 28, 2023
@zvecr @nicsuzor
Custom keycodes in JSON (qmk#19925)
91c8b06
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@zvecr @coquizen
Custom keycodes in JSON (qmk#19925)
dd1d529
@zvecr zvecr mentioned this pull request Nov 14, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
cli qmk cli command keyboard keymap python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @tzarc