Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4pplet/yakiimo Layout Macro Conversion and Additions #20436

Merged
merged 7 commits into from
Apr 16, 2023
Merged

4pplet/yakiimo Layout Macro Conversion and Additions #20436

merged 7 commits into from
Apr 16, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • remove dead space from LAYOUT_all
  • adds four layout macros
  • converts layout macros to data-driven
  • enables Community Layout support

cc @4pplet (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft requested a review from a team April 13, 2023 05:19
@noroadsleft noroadsleft changed the title 4pplet_yakiimo Layout Macro Conversion and Additions 4pplet/yakiimo Layout Macro Conversion and Additions Apr 13, 2023
@drashna drashna requested a review from a team April 15, 2023 09:55
@noroadsleft noroadsleft force-pushed the kb_layouts/4pplet_yakiimo branch from 77624ed to 0e93b5e Compare April 16, 2023 21:26
@noroadsleft noroadsleft changed the base branch from master to develop April 16, 2023 21:27
@noroadsleft noroadsleft merged commit 50ce194 into qmk:develop Apr 16, 2023
@noroadsleft noroadsleft deleted the kb_layouts/4pplet_yakiimo branch April 16, 2023 22:34
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
4pplet/yakiimo Layout Macro Conversion and Additions (qmk#20436)
8acf898 
* add matrix_diagram.md

* info.json: apply friendly formatting

* add LAYOUT_tkl_ansi_tsangan_split_bs_rshift

* add LAYOUT_tkl_ansi_tsangan

* add LAYOUT_tkl_iso_tsangan_split_bs_rshift

* add LAYOUT_tkl_iso_tsangan

* enable Community Layout support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noroadsleft @drashna