Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD extra configs for Split Keyboard #21600

Closed
wants to merge 3 commits into from
Closed

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Jul 24, 2023

Description

Config migration for split_hand_matrix_grid*, split_hand_pin*, and split_haptic_enable.

    "split": {
        "split_pin": {
            "pin": "D3"
            "low_left": true
        }
    }
    "split": {
        "matrix_grid": {
            "pins": ["D3", "D2"]
            "low_right": true
        }
    }
    "split": {
        "haptic": true
    }

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@dunk2k
Copy link
Contributor Author

dunk2k commented Jul 24, 2023

Would folk be able to test these changes with keyboards that have the above migrated config.h setting(s)?

@sigprof
Copy link
Contributor

sigprof commented Jul 24, 2023

See #18254 — as usual, split issues are complicated.

@github-actions github-actions bot added python cli qmk cli command labels Jul 24, 2023
@dunk2k
Copy link
Contributor Author

dunk2k commented Jul 24, 2023

Closing as linked PR takes precedence

@dunk2k dunk2k closed this Jul 24, 2023
@dunk2k dunk2k deleted the handed_dd branch July 24, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants