S65-X refactor and Configurator support #3306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this good or not? I don't understand what we're waiting on here. |
|
Sorry, no, looks ready to go. |
|
Thanks! |
alexey-danilov
pushed a commit
to alexey-danilov/qmk_firmware
that referenced
this pull request
Jul 27, 2018
* Matrix refactor: add S65-Plus matrices * Fix description identifier * Readme cleanup * Configurator support * Add s65plus default keymap
ChrissiQ
pushed a commit
to ChrissiQ/qmk_firmware
that referenced
this pull request
Sep 25, 2018
* Matrix refactor: add S65-Plus matrices * Fix description identifier * Readme cleanup * Configurator support * Add s65plus default keymap
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
* Matrix refactor: add S65-Plus matrices * Fix description identifier * Readme cleanup * Configurator support * Add s65plus default keymap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed the variable at the top of
s65_x.h.The note in the
.hfile about the extra two columns in the matrix (submitted by @geofflane in #1384) prompted me to try to figure out why they were there. My research led me to discover the Sentraq S65-Plus. I was able to find some information in Sentraq's documentation that gave the pinouts for the S65-X and the S65-Plus. The pinouts are identical outside of the two columns of function keys that are to the left on the Plus. I'm thinking perhaps the S65-X is simply an S65-Plus with the two left columns snapped off the PCB.config.halready had the pins assigned for the two left columns, so to me this would seem to indicate both keyboards can run the same firmware. As such, I added duplicates of the existing matrices with the two columns added, asLAYOUT_plus_ansiandLAYOUT_plus_iso, as well as thes65pluskeymap, which is the default keymap for the S65-Plus as published by Sentraq.Configurator support is added with a new
info.jsonfile,config.halso gets a minor change to the USB Device descriptor, and thereadme.mdfile gets some white space changes for formatting purposes.Tagging @mechmerlin who did some work on this board in #2708