Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add userspace files for vosechu #4912

Merged
merged 3 commits into from
Jan 26, 2019
Merged

Add userspace files for vosechu #4912

merged 3 commits into from
Jan 26, 2019

Conversation

vosechu
Copy link
Contributor

@vosechu vosechu commented Jan 22, 2019

Description

Add the vosechu.h/c userspace files. Nothing really interesting to see here, but it's the foundation of a bunch of other PRs I'm going to send in.

I would love help making sure this is the latest thinking! Even though it works in my layouts, I am not well versed in the QMK way of thinking (yet!) so I would very much value feedback!

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Issues Fixed or Closed by this PR

  • None

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Jan 22, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config.h one is the main thing. Everything else is just formatting, and isn't as important.

@drashna drashna added the keymap label Jan 22, 2019
@vosechu
Copy link
Contributor Author

vosechu commented Jan 23, 2019

@drashna Would love a second look at this. Will squash commits after review.

drashna
drashna requested changes Jan 25, 2019
View reviewed changes
@vosechu
Copy link
Contributor Author

vosechu commented Jan 26, 2019

@drashna Added the changes you suggested, thank you so much! Would love any additional thoughts!

Am I doing the SAFE_RANGE thing correctly here: https://github.com/qmk/qmk_firmware/pull/4912/files#diff-d1e15f1985a2c8df7a7009bdf188b1aeR17 ?

The reason I ask is that sometimes when I compile, PAWFIVE doesn't work at all, or sometimes it'll output 'e' or 'c'. That makes me think I'm doing something terribly wrong. Maybe it's the mixing of SAFE_RANGE for userspace_custom_keycodes while using integers for my userspace_custom_layers?

@drashna
Copy link
Member

drashna commented Jan 26, 2019

Awesome!

And yes, that's the proper way to handle the SAFE_RANGE. At least, I sure hope it is, because it's what i"m using too.

As for the pawfive, that may be related to the OS. While it says "pawfive", this is dependant on the host system's layout.

So if you were using the OS colemak layout (eg, not in firmware), it would output jibberish.

@vosechu
Copy link
Contributor Author

vosechu commented Jan 26, 2019

Wonderful! Thank you!

@drashna
Copy link
Member

drashna commented Jan 26, 2019

Looks great! Thanks!

@drashna drashna merged commit 0772b49 into qmk:master Jan 26, 2019
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Jan 27, 2019
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
b7f634d 
* 'master' of https://github.com/qmk/qmk_firmware:
  Fix Command feature: use get_mods() instead of keyboard_report->mods (qmk#4955)
  [Keymap] Small improvements to Maxr1998's Contra keymap (qmk#4952)
  [Keymap] Minor updates to my dz60 keymap (qmk#4943)
  [Keyboard] UniGo66 keyboard added (qmk#4913)
  [Keymap] Move Iris via support to Via keymap (qmk#4893)
  Adds a default value for IS_COMMAND for COMMAND feature (qmk#4301)
  [Keyboard] drop unused i2c files (qmk#4948)
  [Keymap] Add Maxim keymap for Fourier (qmk#4534)
  use built-in arm stuff
  [Keymap] Add userspace files for vosechu (qmk#4912)
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Feb 2, 2019
@vosechu @zer09
[Keymap] Add userspace files for vosechu (qmk#4912)
8f42551 
* Add userspace files for vosechu

* Code review corrections

* Few more code review corrections
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
@vosechu
[Keymap] Add userspace files for vosechu (qmk#4912)
530166d 
* Add userspace files for vosechu

* Code review corrections

* Few more code review corrections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vosechu @drashna