[Keyboard] Added xealousbrown keyboard. #4945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested changes
Jan 26, 2019
Added bootloader. Co-Authored-By: alex-ong <[email protected]>
vomindoraan
reviewed
Jan 27, 2019
drashna
requested changes
Jan 27, 2019
Commented out IS_COMMAND() since it is already default value. Co-Authored-By: alex-ong <[email protected]>
|
Going off the whole "defaults" argument, Col2Row is also the default - so is that required/removable? |
This is a hardware dependant setting, and I personally feel that it should be left "as is", so it's clearly set per keyboard. Otherwise, this looks good! |
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Feb 9, 2019
* Added xealousbrown keyboard. * Changed to pragma once in config.h * Update keyboards/handwired/xealousbrown/rules.mk Added bootloader. Co-Authored-By: alex-ong <[email protected]> * Update keyboards/handwired/xealousbrown/config.h Commented out IS_COMMAND() since it is already default value. Co-Authored-By: alex-ong <[email protected]>
dlhextall
pushed a commit
to dlhextall/qmk_firmware
that referenced
this pull request
May 24, 2019
* Added xealousbrown keyboard. * Changed to pragma once in config.h * Update keyboards/handwired/xealousbrown/rules.mk Added bootloader. Co-Authored-By: alex-ong <[email protected]> * Update keyboards/handwired/xealousbrown/config.h Commented out IS_COMMAND() since it is already default value. Co-Authored-By: alex-ong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new keyboard
Description
Ported my keyboard from TMK to QMK. Now i can actually test changes in QMK :)
Types of changes
Checklist: