Created Southpole keyboard folder #4946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added southpole keyboard folder and files including keymaps folder. Keymaps have errors and will not compile yet
added manufacturer and product name and description
changed formating added layer
noroadsleft
requested changes
Jan 26, 2019
There was a problem hiding this comment.
In addition to the comments below, the keyboard should have a readme file at keyboards/southpole/readme.md.
See quantum/template/avr/readme.md for the template.
Co-Authored-By: ericduns <[email protected]>
Co-Authored-By: ericduns <[email protected]>
vomindoraan
reviewed
Jan 27, 2019
noroadsleft
requested changes
Jan 27, 2019
|
Ok, I'm a n00b (easy to tell I'm sure) when it comes to qmk, but since making the suggested changes I've broke everything lol. Everything was compiling before, now I got 99 errors and not 1 .hex file. Please guide me lol. |
noroadsleft
requested changes
Jan 27, 2019
|
So, this is a limited, one time run board, or? Eg, if someone wanted this. how would they get one, aside from /r/mm? |
|
Yeah its limited run as of right now. Its possible there will be a rev2 but
nothing solid.
…On Sun, Jan 27, 2019, 6:09 PM Drashna Jaelre ***@***.*** wrote:
So, this is a limited, one time run board, or?
Eg, if someone wanted this. how would they get one, aside from /r/mm?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4946 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMT3cKSKVTd-ErOj-WpP23quV6d2CXnJks5vHk3CgaJpZM4aUDRa>
.
|
|
Thanks! |
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Feb 9, 2019
* Added southpole keyboard added southpole keyboard folder and files including keymaps folder. Keymaps have errors and will not compile yet * Add files via upload added manufacturer and product name and description * Update config.h * Add files via upload changed formating added layer * cleaned up files, fixed foobeard keymap, and added maker info * fixed keymap files * Update keyboards/southpole/keymaps/foobeard/keymap.c Co-Authored-By: ericduns <[email protected]> * Update keyboards/southpole/keymaps/default/keymap.c Co-Authored-By: ericduns <[email protected]> * made changes fixing outdated lines and added readme.md * made requested changes for pr to all files * removed vs code and added new line to southpole.h
dlhextall
pushed a commit
to dlhextall/qmk_firmware
that referenced
this pull request
May 24, 2019
* Added southpole keyboard added southpole keyboard folder and files including keymaps folder. Keymaps have errors and will not compile yet * Add files via upload added manufacturer and product name and description * Update config.h * Add files via upload changed formating added layer * cleaned up files, fixed foobeard keymap, and added maker info * fixed keymap files * Update keyboards/southpole/keymaps/foobeard/keymap.c Co-Authored-By: ericduns <[email protected]> * Update keyboards/southpole/keymaps/default/keymap.c Co-Authored-By: ericduns <[email protected]> * made changes fixing outdated lines and added readme.md * made requested changes for pr to all files * removed vs code and added new line to southpole.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a folder for the southpole keyboard created by u/waxpoetic. The folder includes all necessary files as well as a modified keymap file.
Types of changes
Issues Fixed or Closed by this PR
Checklist: