Fix layouts for S7 Elephant in info.json #4989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following layouts were being rendered with 6.75u Spacebars instead of 7u: - LAYOUT_ansi_blocker_7u - LAYOUT_ansi_blocker_7u_small_lshift - LAYOUT_ansi_blocker_7u_small_bspc - LAYOUT_ansi_blocker_7u_small_lshift_small_bspc - LAYOUT_iso_blocker_7u This commit corrects this issue. Flagged by yanfali on QMK Discord.
|
Yeah, the json file is massive with a plethora of layouts, so there was a great chance of me messing up something. lgtm |
|
@Erovia don't feel too bad. I was very impressed with your work. I would not have had that patience lol. lgtm, merging |
mechmerlin
approved these changes
Jan 28, 2019
Quoted for truth. |
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Feb 9, 2019
The following layouts were being rendered with 6.75u Spacebars instead of 7u: - LAYOUT_ansi_blocker_7u - LAYOUT_ansi_blocker_7u_small_lshift - LAYOUT_ansi_blocker_7u_small_bspc - LAYOUT_ansi_blocker_7u_small_lshift_small_bspc - LAYOUT_iso_blocker_7u This commit corrects this issue. Flagged by yanfali on QMK Discord.
dlhextall
pushed a commit
to dlhextall/qmk_firmware
that referenced
this pull request
May 24, 2019
The following layouts were being rendered with 6.75u Spacebars instead of 7u: - LAYOUT_ansi_blocker_7u - LAYOUT_ansi_blocker_7u_small_lshift - LAYOUT_ansi_blocker_7u_small_bspc - LAYOUT_ansi_blocker_7u_small_lshift_small_bspc - LAYOUT_iso_blocker_7u This commit corrects this issue. Flagged by yanfali on QMK Discord.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following layouts were being rendered with 6.75u Spacebars instead of 7u:
This commit corrects this issue.
Flagged by yanfali on QMK Discord.
Tagging @Erovia, who submitted the board to QMK. (Don't know any other way to reach you.)