[Docs] Fix typo in RGB Matrix Driver configuration #5182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not 100% about this stuff, so I've flagged those that would be. |
skullydazed
approved these changes
Feb 20, 2019
|
Awesome, thanks! |
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Mar 2, 2019
* Fix qmk#3797 firmware not compiling If DRIVER_COUNT 1 firmware will not compile. * Fix typo
slugger7
pushed a commit
to slugger7/qmk_firmware
that referenced
this pull request
Mar 7, 2019
* Fix qmk#3797 firmware not compiling If DRIVER_COUNT 1 firmware will not compile. * Fix typo
slugger7
pushed a commit
to slugger7/qmk_firmware
that referenced
this pull request
Apr 3, 2019
* Fix qmk#3797 firmware not compiling If DRIVER_COUNT 1 firmware will not compile. * Fix typo
dlhextall
pushed a commit
to dlhextall/qmk_firmware
that referenced
this pull request
May 24, 2019
* Fix qmk#3797 firmware not compiling If DRIVER_COUNT 1 firmware will not compile. * Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1
Fix compiling problems with the default settings in the documentation #3797.
Firmware does not compile with DRIVER_COUNT 1
Commit 2
The calculation for the matrix position is wrong
NUMBER_OF_ROWS and NUMBER_OF_COLS should be switched
In qmk_firmware/keyboards/planck/light/light.c
x = 224 / ( NUMBER_OF_COLS - 1 )
20.36 = 224/ (12-1)
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist