Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add short aliases for Magic keycodes #7541

Merged
merged 3 commits into from
Dec 5, 2019
Merged

Add short aliases for Magic keycodes #7541

merged 3 commits into from
Dec 5, 2019

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Dec 4, 2019

Description

🦆

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team December 4, 2019 00:29
noroadsleft
noroadsleft approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to consider doing NK_ON and NK_OFF aliases as well?

@fauxpark
Copy link
Member Author

fauxpark commented Dec 4, 2019

Funnily enough, I thought up some aliases for the rest of the Magic keycodes, but thought it should be for the next PR. I can roll it up into this one, though?

@noroadsleft
Copy link
Member

Funnily enough, I thought up some aliases for the rest of the Magic keycodes, but thought it should be for the next PR. I can roll it up into this one, though?

Either way works for me; they're aliases so it's not a high-impact change that's risking breaking something.

@fauxpark fauxpark changed the title Add short alias for MAGIC_TOGGLE_NKRO Add short aliases for Magic keycodes Dec 4, 2019
@drashna drashna merged commit 3ad389d into qmk:master Dec 5, 2019
@fauxpark fauxpark deleted the nk-togg branch December 5, 2019 08:55
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Dec 10, 2019
@fauxpark @drashna
Add short aliases for Magic keycodes (qmk#7541)
637ecea 
* Add short alias for `MAGIC_TOGGLE_NKRO`

* Add aliases for the other Bootmagic keycodes

* Replace long form in default keymaps
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@fauxpark @patrl
Add short aliases for Magic keycodes (qmk#7541)
65d7051 
* Add short alias for `MAGIC_TOGGLE_NKRO`

* Add aliases for the other Bootmagic keycodes

* Replace long form in default keymaps
@drashna drashna mentioned this pull request Jan 2, 2020
Merged
fdidron added a commit to zsa/qmk_firmware that referenced this pull request Jan 6, 2020
@drashna @yanfali
@zvecr @manna-harbour @fauxpark @fdidron
Big keycode cleanup (#230)
6396419 
* clean up quantum.c (qmk#7485)

* idea

* progress

* more stuff

* wip

* wip

* last couple of keycodes you can move safely

* Update quantum/quantum.c

Co-Authored-By: fauxpark <[email protected]>

* Put back RGB_MODE_BREATHE

* Compile out some keycode processing when features are disabled (qmk#7506)

* Add shift-to-invert to remaining directional RGB_* keycode pairs (qmk#7484)

* Add shift-to-invert to remaining directional RGB_* keycode pairs

RGB_MODE_FORWARD / RGB_MODE_REVERSE invert their functions when shift is held.
This change adds the same capabilities to the remaining directional RGB_*
keycode pairs.  This improves consistency and provides full RGB control in a
keymap containing only one keycode from each pair.

* remove redundant variable

* fix typo

* Fix more typos

Flyspell is on now I swear!

* Relocate magic keycode processing (qmk#7512)

* Move magic keycode processing to own file

* Save some bytes

* Update comments

* Update define to one thats not already used...

* Fix audio

* Fix breathing toggle when rgb is disabled (qmk#7550)

* Ifdef MAGIC_EE_HANDS until #178 drops

revert this commit once it does

* Add short aliases for Magic keycodes (qmk#7541)

* Add short alias for `MAGIC_TOGGLE_NKRO`

* Add aliases for the other Bootmagic keycodes

* Replace long form in default keymaps

* Fix FORCE_NKRO handling (qmk#7601)

* Add until #173 drops

* Relocate RGB keycode processing (qmk#7508)

* Move rgb keycode logic to process_keycode

* Fixes for rgb matrix

* Fixes for mxss

* Fix inc/dec logic, add comments

* Fix return RAINBOW_SWIRL logic

* stop external use of rgb helper functions

* merge fix

* Fix 'defined but not used' when all animations are disabled

Co-authored-by: Yan-Fa Li <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Manna Harbour <[email protected]>
Co-authored-by: fauxpark <[email protected]>
Co-authored-by: Florian Didron <[email protected]>
fdidron added a commit to zsa/qmk_firmware that referenced this pull request Jan 8, 2020
@drashna @yanfali
@zvecr @manna-harbour @fauxpark @fdidron
Big keycode cleanup (#230)
493c675 
* clean up quantum.c (qmk#7485)

* idea

* progress

* more stuff

* wip

* wip

* last couple of keycodes you can move safely

* Update quantum/quantum.c

Co-Authored-By: fauxpark <[email protected]>

* Put back RGB_MODE_BREATHE

* Compile out some keycode processing when features are disabled (qmk#7506)

* Add shift-to-invert to remaining directional RGB_* keycode pairs (qmk#7484)

* Add shift-to-invert to remaining directional RGB_* keycode pairs

RGB_MODE_FORWARD / RGB_MODE_REVERSE invert their functions when shift is held.
This change adds the same capabilities to the remaining directional RGB_*
keycode pairs.  This improves consistency and provides full RGB control in a
keymap containing only one keycode from each pair.

* remove redundant variable

* fix typo

* Fix more typos

Flyspell is on now I swear!

* Relocate magic keycode processing (qmk#7512)

* Move magic keycode processing to own file

* Save some bytes

* Update comments

* Update define to one thats not already used...

* Fix audio

* Fix breathing toggle when rgb is disabled (qmk#7550)

* Ifdef MAGIC_EE_HANDS until #178 drops

revert this commit once it does

* Add short aliases for Magic keycodes (qmk#7541)

* Add short alias for `MAGIC_TOGGLE_NKRO`

* Add aliases for the other Bootmagic keycodes

* Replace long form in default keymaps

* Fix FORCE_NKRO handling (qmk#7601)

* Add until #173 drops

* Relocate RGB keycode processing (qmk#7508)

* Move rgb keycode logic to process_keycode

* Fixes for rgb matrix

* Fixes for mxss

* Fix inc/dec logic, add comments

* Fix return RAINBOW_SWIRL logic

* stop external use of rgb helper functions

* merge fix

* Fix 'defined but not used' when all animations are disabled

Co-authored-by: Yan-Fa Li <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Manna Harbour <[email protected]>
Co-authored-by: fauxpark <[email protected]>
Co-authored-by: Florian Didron <[email protected]>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@fauxpark @HokieGeek
Add short aliases for Magic keycodes (qmk#7541)
695950d 
* Add short alias for `MAGIC_TOGGLE_NKRO`

* Add aliases for the other Bootmagic keycodes

* Replace long form in default keymaps
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@fauxpark @drashna
Add short aliases for Magic keycodes (qmk#7541)
21184a8 
* Add short alias for `MAGIC_TOGGLE_NKRO`

* Add aliases for the other Bootmagic keycodes

* Replace long form in default keymaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@zvecr zvecr zvecr approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
core documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fauxpark @noroadsleft @drashna @zvecr