Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new keyboard: Magnavox Videowriter convertion with Pro Micro #7634

Merged
merged 17 commits into from
Dec 17, 2019
Merged

new keyboard: Magnavox Videowriter convertion with Pro Micro #7634

merged 17 commits into from
Dec 17, 2019

Conversation

DmNosachev
Copy link
Contributor

USB-convertion project for Alps-based Magnavox Videowriter keyboards using stock PCB and Pro Micro AVR board.

Both included keymaps compile and work. I don't know how to check my info.json file without online QMK Configurator.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

noroadsleft
noroadsleft requested changes Dec 15, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of small suggestions here. Jump over to the Files Changed tab and you can apply multiple suggestions per commit.

Nice conversion!

fauxpark
fauxpark requested changes Dec 15, 2019
View reviewed changes
DmNosachev and others added 12 commits December 16, 2019 10:12
@DmNosachev @noroadsleft
Update keyboards/handwired/videowriter/info.json
719b98a 
Co-Authored-By: James Young <[email protected]>
@DmNosachev @noroadsleft
Update keyboards/handwired/videowriter/README.md
f3a3e27 
Co-Authored-By: James Young <[email protected]>
@DmNosachev @noroadsleft
Update keyboards/handwired/videowriter/README.md
3fe529b 
Co-Authored-By: James Young <[email protected]>
@DmNosachev @noroadsleft
Update keyboards/handwired/videowriter/info.json
cea12d2 
Co-Authored-By: James Young <[email protected]>
@DmNosachev @noroadsleft
Update keyboards/handwired/videowriter/info.json
03c0f2e 
Co-Authored-By: James Young <[email protected]>
@DmNosachev @noroadsleft
Update keyboards/handwired/videowriter/info.json
57b9a7c 
Co-Authored-By: James Young <[email protected]>
@DmNosachev @noroadsleft
Update keyboards/handwired/videowriter/info.json
afc3716 
Co-Authored-By: James Young <[email protected]>
@DmNosachev @noroadsleft
Update keyboards/handwired/videowriter/info.json
583bab1 
Co-Authored-By: James Young <[email protected]>
@DmNosachev
suggested changes
e793f86
@DmNosachev
Merge branch 'dev_branch' of https://github.com/DmNosachev/qmk_firmware…
d74e1cf 
… into dev_branch
@DmNosachev
suggested changes
4a61df2
@DmNosachev
fix comment symbol
77e6c32
fauxpark
fauxpark requested changes Dec 16, 2019
View reviewed changes
drashna
drashna approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@drashna drashna requested a review from a team December 16, 2019 19:19
noroadsleft
noroadsleft approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit 4ebecc4 into qmk:master Dec 17, 2019
@noroadsleft
Copy link
Member

Thanks!

@DmNosachev DmNosachev deleted the dev_branch branch December 18, 2019 13:38
benjaminmikiten added a commit to benjaminmikiten/qmk_firmware that referenced this pull request Dec 18, 2019
@benjaminmikiten
Merge branch 'master' into develop
db79a5b 
* master: (99 commits)
  [Keymap] Added userspace for d4mation. Included their keymap for the Atreus62 (qmk#7483)
  [Keymap] Custom user keymap for Think6.5 with LED range control (qmk#7603)
  [Keymap] CRKBD Custom Keymap - KidBrazil (qmk#7630)
  [Keymap] Add pico 70 keys keymap (qmk#7654)
  Tidy up dztech default keymaps and info.json (qmk#7608)
  Heisenberg handwired keyboard added (qmk#7643)
  [Keyboard] Added Filco Majestouch TKL Pegasus Hoof ISO Layout (qmk#7647)
  Ported J80 to QMK (qmk#7488)
  [Keyboard] Magnavox Videowriter conversion with Pro Micro (qmk#7634)
  [Docs] add japanese translation (basic part) (qmk#7461)
  Tidy up dztech rules.mk
  Relocate RGB keycode processing (qmk#7508)
  Move kwerdenker's personal keymap from RGB (qmk#7645)
  Remove QMK_KEYBOARD_CONFIG_H from boards (qmk#7635)
  Disable usb on slave half to resolve random 'lockup' (qmk#7649)
  [Core] Optimize matrix processing (qmk#7621)
  [Keymap] boy_314's satisfaction75 layout (qmk#7638)
  [Keyboard] XD68 65% ATMega32U4 based (qmk#7395)
  [keyboard] Plain60 cleanups (qmk#7644)
  update default h88 keymap (qmk#7646)
  ...
akrob pushed a commit to akrob/qmk_firmware that referenced this pull request Dec 28, 2019
Merge remote-tracking branch 'upstream/master'
6edd8aa 
* upstream/master: (1080 commits)
  Update toshi0383 keymap (qmk#7700)
  Completely remove i2c_transmit_receive function (qmk#7686)
  Readded lost pgm_read_word code to encoder array lookups (qmk#7577)
  Add central location for ChibiOS defines (qmk#7542)
  Add TADA68 keymap/rules/config for QMK bootloader (qmk#7679)
  [Docs] fix docs (qmk#7642)
  [Keyboard] Clueboard 60 fix col 11 12 mixup (qmk#7685)
  Missed these LTO blocks
  I corrected my name.
  [Keymap] Added userspace for d4mation. Included their keymap for the Atreus62 (qmk#7483)
  [Keymap] Custom user keymap for Think6.5 with LED range control (qmk#7603)
  [Keymap] CRKBD Custom Keymap - KidBrazil (qmk#7630)
  [Keymap] Add pico 70 keys keymap (qmk#7654)
  Improve docs "Edit Document" footer
  Tidy up dztech config.h
  Tidy up dztech default keymaps and info.json (qmk#7608)
  Heisenberg handwired keyboard added (qmk#7643)
  [Keyboard] Added Filco Majestouch TKL Pegasus Hoof ISO Layout (qmk#7647)
  Ported J80 to QMK (qmk#7488)
  [Keyboard] Magnavox Videowriter conversion with Pro Micro (qmk#7634)
  ...
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@DmNosachev @patrl
[Keyboard] Magnavox Videowriter conversion with Pro Micro (qmk#7634)
fd71232 
* Magnavox Videowriter convertion

* Magnavox Videowriter: readme, images

* Update keyboards/handwired/videowriter/info.json

* Update keyboards/handwired/videowriter/README.md

* Update keyboards/handwired/videowriter/README.md

* Update keyboards/handwired/videowriter/info.json

* Update keyboards/handwired/videowriter/info.json

* Update keyboards/handwired/videowriter/info.json

* Update keyboards/handwired/videowriter/info.json

* Update keyboards/handwired/videowriter/info.json

* suggested changes

* suggested changes

* fix comment symbol

* Update keyboards/handwired/videowriter/rules.mk

* Update keyboards/handwired/videowriter/rules.mk

* Update keyboards/handwired/videowriter/rules.mk
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@DmNosachev @HokieGeek
[Keyboard] Magnavox Videowriter conversion with Pro Micro (qmk#7634)
0e49c51 
* Magnavox Videowriter convertion

* Magnavox Videowriter: readme, images

* Update keyboards/handwired/videowriter/info.json

* Update keyboards/handwired/videowriter/README.md

* Update keyboards/handwired/videowriter/README.md

* Update keyboards/handwired/videowriter/info.json

* Update keyboards/handwired/videowriter/info.json

* Update keyboards/handwired/videowriter/info.json

* Update keyboards/handwired/videowriter/info.json

* Update keyboards/handwired/videowriter/info.json

* suggested changes

* suggested changes

* fix comment symbol

* Update keyboards/handwired/videowriter/rules.mk

* Update keyboards/handwired/videowriter/rules.mk

* Update keyboards/handwired/videowriter/rules.mk
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@DmNosachev @kujawakk
[Keyboard] Magnavox Videowriter conversion with Pro Micro (qmk#7634)
38e53fd 
* Magnavox Videowriter convertion

* Magnavox Videowriter: readme, images

* Update keyboards/handwired/videowriter/info.json

* Update keyboards/handwired/videowriter/README.md

* Update keyboards/handwired/videowriter/README.md

* Update keyboards/handwired/videowriter/info.json

* Update keyboards/handwired/videowriter/info.json

* Update keyboards/handwired/videowriter/info.json

* Update keyboards/handwired/videowriter/info.json

* Update keyboards/handwired/videowriter/info.json

* suggested changes

* suggested changes

* fix comment symbol

* Update keyboards/handwired/videowriter/rules.mk

* Update keyboards/handwired/videowriter/rules.mk

* Update keyboards/handwired/videowriter/rules.mk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DmNosachev @noroadsleft @drashna @fauxpark