Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Keymap] Improvements to KidBrazil keymap to better handle OLED/LED Matrix timeout. #7688
[Keymap] Improvements to KidBrazil keymap to better handle OLED/LED Matrix timeout. #7688
Changes from 11 commits
4904a3c
eed0be8
6de75b5
f1e3382
285ccd9
b85491c
027c454
ae43b73
0280137
3450f3b
19e7051
bd6194c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a logic bug here. Although the variable is named
oled_timer
, it's used to timeout both the RGB Matrix and the OLEDs. As it's written, disabling the OLEDs will break the RGB Matrix timeout becauseoled_timer
will not be set.To resolve it, I recommend renaming
oled_timer
totimeout_timer
and remove the conditionalifdef
here.