Refactor existing SPI ws2812 implementations #7694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
zvecr
force-pushed
the
feature/ws2812_spi_board_refactor
branch
2 times, most recently
from
bfb5366 to
261e1b2
Compare
|
Rebased now #7674 has been merged Edit: Travis build failures are due to audio/backlight support being assumed in community layouts. |
|
I'll test this tomorrow! Looks pretty good to me but will double check. |
zvecr
force-pushed
the
feature/ws2812_spi_board_refactor
branch
from
261e1b2 to
5617c89
Compare
zvecr
force-pushed
the
feature/ws2812_spi_board_refactor
branch
from
5617c89 to
f695ed5
Compare
fauxpark
approved these changes
Jan 27, 2020
zvecr
force-pushed
the
feature/ws2812_spi_board_refactor
branch
from
e3d8efb to
fc76b0e
Compare
zvecr
force-pushed
the
feature/ws2812_spi_board_refactor
branch
from
fc76b0e to
8a93ac3
Compare
zvecr
force-pushed
the
feature/ws2812_spi_board_refactor
branch
from
8a93ac3 to
feecd45
Compare
13 tasks
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Apr 10, 2020
violet-fish
pushed a commit
to violet-fish/qmk_firmware
that referenced
this pull request
Apr 12, 2020
Quarren42
pushed a commit
to Quarren42/qmk_firmware
that referenced
this pull request
Apr 15, 2020
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
bitherder
pushed a commit
to bitherder/qmk_firmware
that referenced
this pull request
May 15, 2020
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
May 24, 2020
turky
pushed a commit
to turky/qmk_firmware
that referenced
this pull request
Jun 13, 2020
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
thorstenweber83
pushed a commit
to thorstenweber83/qmk_firmware
that referenced
this pull request
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that we have the SPI based ws2812 driver migrated to core, this PR aims to remove the existing implementations and migrate to the core provided ones.
Tagging @awkannan as maintainer
Types of Changes
Checklist