-
-
Notifications
You must be signed in to change notification settings - Fork 40.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Arm Teensys to mcu_selection.mk #8026
Conversation
@Oryhara just a heads up as this modifies your keymap's rules.mk (only to remove stuff that is already inherited from the top-level rules.mk, and the MCU selection makefile) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth having MK20DX128 in cores mcu selection, when its only used on 1 board?
Edit: breaking changes till we can get user keymap changes approved.
I did notice that, but I'm under the impression the onekey boards are kind of "example" code (as well as a testbed), so I'd prefer to reduce the boilerplate even if no real boards are using the Teensy LC yet. It should also help with the MCU selection in the new keyboard Python script. |
MK20DX128 was infinity60, though that does remind me i have yet to PT the lc support for 40percentclub/i75. |
Don't know why I read that as MKL26Z64... my answer then is "for completeness" cf. https://docs.qmk.fm/#/compatible_microcontrollers |
@Oryhara Are you okay with the changes to |
In the interest of pushing this along I've rolled back the changes to the halfkeyboard keymap - this is no longer a breaking change. |
* upstream/master: (330 commits) Add Danish keymap and sendstring LUT (qmk#8218) format code according to conventions [skip ci] uart.c fix from TMK (qmk#7628) S75 Encoder Fixes (qmk#7758) Add Turkish keymap aliases and sendstring LUT (qmk#7676) Add Arm Teensys to mcu_selection.mk (qmk#8026) [New keyboard]silverbullet44 (qmk#7950) Allow 30us matrix delay to be keyboard/user overridable (qmk#8216) Merge /prime_l and /prime_l_v2 (qmk#8194) [Keymap] Keymap for XD75 with 7U spacebar EN-RU gamers (qmk#8184) Add VIA support for kbd8x mk2 (qmk#8168) Move Grave/Tilde and some lesser used keys on my ergo boards (qmk#8200) [Keyboard] KC60SE cleanup (qmk#8171) Made windows driver installation accept y as All to allow CI (qmk#8189) Change the image photo of /keyboards/reviung41/readme.md (qmk#8195) MxSS RGB Handler Touchup (qmk#8105) Centromere Configurator layout support and readme update (qmk#8190) dynamic keymap sanity check (qmk#8181) [keyboard] Austin (qmk#8176) Use pathlib everywhere we can (qmk#7872) ...
* Add Arm Teensys to mcu_selection.mk * Roll back halfkeyboard keymap changes * Remove extra newline
* 'master' of https://github.com/nesth/qmk_firmware: (331 commits) helix like crkbd Add Danish keymap and sendstring LUT (qmk#8218) format code according to conventions [skip ci] uart.c fix from TMK (qmk#7628) S75 Encoder Fixes (qmk#7758) Add Turkish keymap aliases and sendstring LUT (qmk#7676) Add Arm Teensys to mcu_selection.mk (qmk#8026) [New keyboard]silverbullet44 (qmk#7950) Allow 30us matrix delay to be keyboard/user overridable (qmk#8216) Merge /prime_l and /prime_l_v2 (qmk#8194) [Keymap] Keymap for XD75 with 7U spacebar EN-RU gamers (qmk#8184) Add VIA support for kbd8x mk2 (qmk#8168) Move Grave/Tilde and some lesser used keys on my ergo boards (qmk#8200) [Keyboard] KC60SE cleanup (qmk#8171) Made windows driver installation accept y as All to allow CI (qmk#8189) Change the image photo of /keyboards/reviung41/readme.md (qmk#8195) MxSS RGB Handler Touchup (qmk#8105) Centromere Configurator layout support and readme update (qmk#8190) dynamic keymap sanity check (qmk#8181) [keyboard] Austin (qmk#8176) ...
* Add Arm Teensys to mcu_selection.mk * Roll back halfkeyboard keymap changes * Remove extra newline
* Add Arm Teensys to mcu_selection.mk * Roll back halfkeyboard keymap changes * Remove extra newline
* Add Arm Teensys to mcu_selection.mk * Roll back halfkeyboard keymap changes * Remove extra newline
* Add Arm Teensys to mcu_selection.mk * Roll back halfkeyboard keymap changes * Remove extra newline
* Add Arm Teensys to mcu_selection.mk * Roll back halfkeyboard keymap changes * Remove extra newline
* Add Arm Teensys to mcu_selection.mk * Roll back halfkeyboard keymap changes * Remove extra newline
Description
🍔
Types of Changes
Issues Fixed or Closed by This PR
Checklist