Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom preonic layout optimised for programming #8263

Merged
merged 10 commits into from
May 6, 2020

Conversation

AlexDaigre
Copy link
Contributor

@AlexDaigre AlexDaigre commented Feb 28, 2020

Layout Images

Don Gato's programming Layout

The default Preonic layout is suited to general english typing but not very convent to program on. This is my custom layout to re-optimise the keyboard for programming tasks.
I have been programming with this keyboard layout at work and I found it much faster and easier to adjust to than the default layout.

  • Removed keys on the RAISE, LOWER, and ADJUST layers that duplicated keys on the main QWERTY layout.
  • Moved the control, alt, and gui keys to a more natural position.
  • Added the Caps-lock key on RAISE and LOWER in its position on a standard keyboard.
  • Moved {}[], -_, and | (on RAISE and LOWER) to be close to to similar keys on the QWERTY layout to make them easier to remember. They are kept as close as possible to their locations on a standard layout so users won't have to ADJUST their muscle memory much.
    • (), {}, and [] are all on the 9 and 0 keys. This is where () are placed naturally, so it is easy to find all of your braces.
    • -_ are moved to the += key. Now you can remember that -, +, and = are all together. The keys are also right next to each-other on a standard layout, so it is a very small move.
    • \ and | have beeb moved to the /? key. Easy to remember as / and \ are together.
  • Moved backspace to make room for +=.
  • Added delete to the backspace key on RAISE / LOWER
  • Removed backlight and added an ADJUST key. As the Massdrop kits don't come with backlighting default, I think this is more useful for most users.
  • I have left the Colemak and Dvorak alternate layouts, but they won't map up as conveniently to the other layers.
  • I have included the keyboard layouts so that those wishing to make modifications or new versions of this layout can quickly update their images.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team March 1, 2020 00:20
@drashna drashna added the keymap label Mar 1, 2020
@drashna
Copy link
Member

drashna commented Mar 1, 2020

The only issue I see here, is that we generally prefer to have the keymap folder name match the github user account name. This isn't a hard requirement, but heavily preferred.

Otherwise, looks great!

@drashna drashna requested a review from a team March 4, 2020 08:50
@stale
Copy link

stale bot commented Apr 18, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue I see here, is that we generally prefer to have the keymap folder name match the github user account name. This isn't a hard requirement, but heavily preferred.

I too would prefer if the keymap name matched the GitHub username, but otherwise this looks good.

@AlexDaigre please advise if you'd like this merged as-is, or update the PR and I'll merge it after that happens.

@stale stale bot removed the awaiting changes label Apr 20, 2020
@AlexDaigre
Copy link
Contributor Author

@noroadsleft Thank you for the feedback. I have updated the keymap name. Let me know if there are any other issues.

@noroadsleft
Copy link
Member

@AlexDaigre Looks good. Sorry for the late response.

@noroadsleft noroadsleft merged commit 7bb9c76 into qmk:master May 6, 2020
brandonschlack pushed a commit to brandonschlack/qmk_firmware that referenced this pull request May 7, 2020
* my new layout, draft one, untested.

* updated mapping to include more keys

* updated layout name to be more descriptive. Updated readme with more information.

* added more info to the readme and spellchecked it.

* Added the Json for the keyboard layout images and updated the readme to reflect this.

* Updated Image link

Updated Image link so that it links to the correct place

* updated copyright info to include MY name.

* Updated copyright attribuatation to include the author of the file I modified.

* added the backlighting key back to the adjust layer so that it is usable.

* updated the name of the keymap to match my github name.
@AlexDaigre AlexDaigre deleted the customPreonicLayout branch May 8, 2020 15:48
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
* my new layout, draft one, untested.

* updated mapping to include more keys

* updated layout name to be more descriptive. Updated readme with more information.

* added more info to the readme and spellchecked it.

* Added the Json for the keyboard layout images and updated the readme to reflect this.

* Updated Image link

Updated Image link so that it links to the correct place

* updated copyright info to include MY name.

* Updated copyright attribuatation to include the author of the file I modified.

* added the backlighting key back to the adjust layer so that it is usable.

* updated the name of the keymap to match my github name.
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
* my new layout, draft one, untested.

* updated mapping to include more keys

* updated layout name to be more descriptive. Updated readme with more information.

* added more info to the readme and spellchecked it.

* Added the Json for the keyboard layout images and updated the readme to reflect this.

* Updated Image link

Updated Image link so that it links to the correct place

* updated copyright info to include MY name.

* Updated copyright attribuatation to include the author of the file I modified.

* added the backlighting key back to the adjust layer so that it is usable.

* updated the name of the keymap to match my github name.
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
* my new layout, draft one, untested.

* updated mapping to include more keys

* updated layout name to be more descriptive. Updated readme with more information.

* added more info to the readme and spellchecked it.

* Added the Json for the keyboard layout images and updated the readme to reflect this.

* Updated Image link

Updated Image link so that it links to the correct place

* updated copyright info to include MY name.

* Updated copyright attribuatation to include the author of the file I modified.

* added the backlighting key back to the adjust layer so that it is usable.

* updated the name of the keymap to match my github name.
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
* my new layout, draft one, untested.

* updated mapping to include more keys

* updated layout name to be more descriptive. Updated readme with more information.

* added more info to the readme and spellchecked it.

* Added the Json for the keyboard layout images and updated the readme to reflect this.

* Updated Image link

Updated Image link so that it links to the correct place

* updated copyright info to include MY name.

* Updated copyright attribuatation to include the author of the file I modified.

* added the backlighting key back to the adjust layer so that it is usable.

* updated the name of the keymap to match my github name.
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
* my new layout, draft one, untested.

* updated mapping to include more keys

* updated layout name to be more descriptive. Updated readme with more information.

* added more info to the readme and spellchecked it.

* Added the Json for the keyboard layout images and updated the readme to reflect this.

* Updated Image link

Updated Image link so that it links to the correct place

* updated copyright info to include MY name.

* Updated copyright attribuatation to include the author of the file I modified.

* added the backlighting key back to the adjust layer so that it is usable.

* updated the name of the keymap to match my github name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants