Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jj28 (jj40 SuperMicro) update #8885

Merged
merged 6 commits into from
May 6, 2020
Merged

jj28 (jj40 SuperMicro) update #8885

merged 6 commits into from
May 6, 2020

Conversation

stevexyz
Copy link
Contributor

Description

Fixed broken compilation by new framework for rgb lights and minor embellishments

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr requested changes Apr 24, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like with #8886, jpeg files also need to be removed from this PR too.

@zvecr zvecr added the keymap label Apr 24, 2020
@stevexyz
Copy link
Contributor Author

stevexyz commented Apr 25, 2020 •
edited
Loading

Changes accepted. As for the other revision let me know if you can remove the jpeg files while merging (nothing is breaking) or I should do another PR.
Thank you for revision!

@zvecr
Copy link
Member

zvecr commented Apr 25, 2020 •
edited
Loading

You will need to commit the modifications to this PRs branch and push. There is no need to open another PR.

@stevexyz
Copy link
Contributor Author

You will need to commit the modifications to this PRs branch and push. There is no need to open another PR.

done also here! :)

zvecr
zvecr requested changes May 1, 2020
View reviewed changes
@stevexyz
Copy link
Contributor Author

stevexyz commented May 3, 2020

I think I did all what was requested, or I'm missing something?

@drashna drashna requested a review from a team May 5, 2020 20:04
@zvecr zvecr merged commit 19513fa into qmk:master May 6, 2020
@zvecr
Copy link
Member

zvecr commented May 6, 2020

Thanks!

brandonschlack pushed a commit to brandonschlack/qmk_firmware that referenced this pull request May 7, 2020
@stevexyz @zvecr @brandonschlack
jj28 (jj40 SuperMicro) update (qmk#8885)
e3ee08b 
* jj28 (jj40 SuperMicro) update

* Update keyboards/jj40/keymaps/stevexyz/config.h

Co-Authored-By: Joel Challis <[email protected]>

* removed jpegs

* Update keyboards/jj40/keymaps/stevexyz/keymap.c

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/jj40/keymaps/stevexyz/keymap.c

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/jj40/keymaps/stevexyz/keymap.c

Co-authored-by: Joel Challis <[email protected]>

Co-authored-by: stevexyz <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@stevexyz @zvecr @lorenzoernesto
jj28 (jj40 SuperMicro) update (qmk#8885)
01773ae 
* jj28 (jj40 SuperMicro) update

* Update keyboards/jj40/keymaps/stevexyz/config.h

Co-Authored-By: Joel Challis <[email protected]>

* removed jpegs

* Update keyboards/jj40/keymaps/stevexyz/keymap.c

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/jj40/keymaps/stevexyz/keymap.c

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/jj40/keymaps/stevexyz/keymap.c

Co-authored-by: Joel Challis <[email protected]>

Co-authored-by: stevexyz <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@stevexyz @zvecr @sowbug
jj28 (jj40 SuperMicro) update (qmk#8885)
beee818 
* jj28 (jj40 SuperMicro) update

* Update keyboards/jj40/keymaps/stevexyz/config.h

Co-Authored-By: Joel Challis <[email protected]>

* removed jpegs

* Update keyboards/jj40/keymaps/stevexyz/keymap.c

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/jj40/keymaps/stevexyz/keymap.c

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/jj40/keymaps/stevexyz/keymap.c

Co-authored-by: Joel Challis <[email protected]>

Co-authored-by: stevexyz <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@stevexyz @zvecr @turky
jj28 (jj40 SuperMicro) update (qmk#8885)
7d9f3f7 
* jj28 (jj40 SuperMicro) update

* Update keyboards/jj40/keymaps/stevexyz/config.h

Co-Authored-By: Joel Challis <[email protected]>

* removed jpegs

* Update keyboards/jj40/keymaps/stevexyz/keymap.c

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/jj40/keymaps/stevexyz/keymap.c

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/jj40/keymaps/stevexyz/keymap.c

Co-authored-by: Joel Challis <[email protected]>

Co-authored-by: stevexyz <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@stevexyz @zvecr @jakobaa
jj28 (jj40 SuperMicro) update (qmk#8885)
215e468 
* jj28 (jj40 SuperMicro) update

* Update keyboards/jj40/keymaps/stevexyz/config.h

Co-Authored-By: Joel Challis <[email protected]>

* removed jpegs

* Update keyboards/jj40/keymaps/stevexyz/keymap.c

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/jj40/keymaps/stevexyz/keymap.c

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/jj40/keymaps/stevexyz/keymap.c

Co-authored-by: Joel Challis <[email protected]>

Co-authored-by: stevexyz <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@stevexyz @zvecr @sjmacneil
jj28 (jj40 SuperMicro) update (qmk#8885)
8cefa57 
* jj28 (jj40 SuperMicro) update

* Update keyboards/jj40/keymaps/stevexyz/config.h

Co-Authored-By: Joel Challis <[email protected]>

* removed jpegs

* Update keyboards/jj40/keymaps/stevexyz/keymap.c

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/jj40/keymaps/stevexyz/keymap.c

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/jj40/keymaps/stevexyz/keymap.c

Co-authored-by: Joel Challis <[email protected]>

Co-authored-by: stevexyz <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevexyz @zvecr @drashna @fauxpark