Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deep copy for all fast-pauli objects; new properties for SPO #87

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Deep copy for all fast-pauli objects; new properties for SPO #87

merged 7 commits into from
Dec 17, 2024

Conversation

stand-by
Copy link
Collaborator

General

This PR accomplishes following:

  • Introduces .clone() method for every nanobind wrapper we have
  • Adds properties for coeffs and pauli_strings of SummedPauliOp object
  • New method to split SummedPauliOp into PauliOp components

Related Issues

@stand-by stand-by added the enhancement New feature or request label Dec 13, 2024
jamesETsmith
jamesETsmith requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@jamesETsmith jamesETsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stand-by, this looks good. I've got a couple small changes and a few questions

fast_pauli/cpp/include/__summed_pauli_op.hpp Show resolved Hide resolved
fast_pauli/cpp/include/__summed_pauli_op.hpp Outdated Show resolved Hide resolved
fast_pauli/cpp/include/__summed_pauli_op.hpp Outdated Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Show resolved Hide resolved
fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
fast_pauli/cpp/include/__nb_helpers.hpp Show resolved Hide resolved
jamesETsmith
jamesETsmith requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@jamesETsmith jamesETsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nits

fast_pauli/cpp/src/fast_pauli.cpp Outdated Show resolved Hide resolved
jamesETsmith
jamesETsmith approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@jamesETsmith jamesETsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fast_pauli/cpp/include/__summed_pauli_op.hpp Outdated Show resolved Hide resolved
@stand-by stand-by merged commit bc7676a into main Dec 17, 2024
10 checks passed
@stand-by stand-by deleted the feature/deep-copy branch December 17, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesETsmith jamesETsmith jamesETsmith approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add ability to deep copy fast-pauli objects
2 participants
@stand-by @jamesETsmith