Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate PauliBasis and equal_bases #41

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

akirakyle
Copy link
Member

Reopening #39 here, I guess github doesn't allow reopening a PR after the branch has been force pushed. The actual Pauli operator basis will have a different structure than the currently named PauliBasis. Having a deprecation warning now would be good so give users a chance to realize this. Later, when introducing the actual Pauli operator basis, this allows us the chance to use the PauliBasis name for the actual Pauli operator basis.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 117 lines in your changes missing coverage. Please review.

Project coverage is 32.66%. Comparing base (f22adb7) to head (1b31070).

Files with missing lines Patch % Lines
src/show.jl 0.00% 43 Missing ⚠️
src/linalg.jl 48.61% 37 Missing ⚠️
src/julia_base.jl 0.00% 16 Missing ⚠️
src/deprecated.jl 0.00% 9 Missing ⚠️
src/bases.jl 0.00% 5 Missing ⚠️
src/embed_permute.jl 50.00% 4 Missing ⚠️
src/julia_linalg.jl 0.00% 2 Missing ⚠️
src/identityoperator.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #41       +/-   ##
===========================================
+ Coverage   17.08%   32.66%   +15.58%     
===========================================
  Files          12       13        +1     
  Lines         398      401        +3     
===========================================
+ Hits           68      131       +63     
+ Misses        330      270       -60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant