Fix option lazyLoad: false

[dcyriller]

Description

After #151, option lazyLoad: false is broken.

Changes

• Remove the custom script injection for intlTelInput
• Instead make sure the library is loaded (or load it) and then initialize the component

[Turbo87]

so that essentially removes the lazyLoad option?! 🤔

[dcyriller]

No, it doesn't. The lazyLoading is done here now: https://github.com/qonto/ember-phone-input/blob/v3.1.0/addon/services/phone-input.js#L14

[dcyriller]

You mean: with that PR, the script would always be loaded? The answer to that question is: yes.

With the lazyLoad option set to false, users load the script in the init hook of the phoneInput service (meaning at app boot). Note that previously it was loaded from index.html file. Which is a small change.

If they specify lazyLoad: true. The script won't be loaded at app boot. Instead they will have to load it manually. If they don't, a fallback will load the script before doing the component setup.

[dbendaou]

LGTM

[dcyriller]

@Turbo87 do you have time to review it? If not, I will merge it to release the fix.