Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💥 Drop node 8 support #177

Merged
merged 2 commits into from
Jan 3, 2020
Merged

💥 Drop node 8 support #177

merged 2 commits into from
Jan 3, 2020

Conversation

dbendaou
Copy link
Member

@dbendaou dbendaou commented Jan 3, 2020

Description

This PR aims to drop node 8 support as it has reaches is end of life
see https://nodejs.org/en/about/releases/

Changes

  • Update package.json to udpdate engines
  • Update .travis-ci.yml

@dbendaou dbendaou self-assigned this Jan 3, 2020
@dbendaou dbendaou changed the title Drop node8 💥 Drop node8 Jan 3, 2020
@dbendaou dbendaou changed the title 💥 Drop node8 💥 Drop node 8 support Jan 3, 2020
@dbendaou dbendaou requested a review from dcyriller January 3, 2020 10:27
dcyriller
dcyriller approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@dcyriller dcyriller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this will unblock some devDependencies upgrade.

Do you think you can upgrade that repo too: https://github.com/qonto/ember-autofocus-modifier?

@dbendaou
Copy link
Member Author

dbendaou commented Jan 3, 2020

On it !

@dcyriller dcyriller merged commit 2590ed9 into master Jan 3, 2020
@dcyriller dcyriller deleted the drop-node8 branch January 3, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcyriller dcyriller dcyriller approved these changes

Assignees

@dbendaou dbendaou

Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbendaou @dcyriller