Remove ember-decorators dependency #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiwiupover
changed the title
|
@jacojoubert FYI |
|
@kiwiupover thank you for the reproduction. I'll be able to check it out on Monday, I don't have IE 11 at home. I'd be interested to know the root cause of this transpilation issue. Do you have an idea? |
|
The issue was fixed by adding https://github.com/pzuraq/ember-cli-babel-polyfills which properly compiles the decorators to something IE11 can understand. |
updated super adding input type
Additionnaly, revert native Promise to RSVP's
dcyriller
force-pushed
the
remove-decorators
branch
from
1c093aa to
0ea7f2f
Compare
|
Good to know @jacojoubert. I want to procede with the decorator removal. To do so, I've added two commits. @kiwiupover I've rebased the PR, thank you for your work. |
dcyriller
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the decorators from the
phone-inputcomponentupdated super
adding input type
http://phone-input.surge.sh -> use this branch
http://phone-input-broken.surge.sh -> uses
2.0.5The above app can be found here
https://github.com/kiwiupover/phone-input
https://github.com/kiwiupover/phone-input/tree/broken