-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternate Display for Username in Discord #154
Conversation
That's such a cool idea! I think this would be great as an optional thing in the discord integration config. It takes up more vertical space but I see the appeal. |
I want to add a pfp depending on the color of the username and I have 3 idea how to do it but want your input @quackduck ...
|
I don't really want to make Devzat, which is an SSH server, also an HTTP server but since this is an optional feature, maybe it's okay. I'm thinking that an implementation could work like this:
The hard part is keeping the terminal colors and discord colors the same, because the way messages work in Devzat means that they don't encode color information. So, I think we'd have to just make the color the result of some sender-name-based function. (eg. hash sender name, then convert hash into RGB values with math). Ultimately the end result would be pfps with colors that don't match those in the terminal and are only sender-name-dependent (meaning that if someone changes their name, the color will change too), which is kind of not that big an improvement and now involves a whole HTTP server and PNG generating - all of which presents opportunities for holes and DoS attacks |
oops, closed by mistake |
Added Profile picture colors :) |
That's awesome! Could you attach an example demo screenshot? |
(sry if I hurt your feeling linter... I want to pass this time)
Oh my god that's beautiful |
I wonder if something similar is possible in slack |
https://api.slack.com/methods/chat.postMessage#authorship This is what I found looking through the slack api documentation maybe there'll be the same problem... i don't really know slack tho... Edit: url got cut |
Can the inverse transform be applied to messages send on Discord and read from SSH? It would be nice if the name of Discord users on SSH mirrored the color of their profile pictures. |
Maybe create a new issue? |
This is such a cool feature that I think we should make this the default discord mode. Is there any extra set-up needed on the Discord side? |
It needs "Manage Webhooks" and "Message Content Intent". |
well it would need send message for the new non-default setting |
Might need an update to the docs in that case |
I think we just need to confirm I didn't break anything with my changes |
Epic PR, thanks for this |
Edit: This requires the bot to have the permissions manage Webhooks (I think I just gave it Admin xD)