Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust HTML capture regex #175

Merged
merged 1 commit into from
May 6, 2018
Merged

adjust HTML capture regex #175

merged 1 commit into from
May 6, 2018

Conversation

quantizor
Copy link
Owner

should close #170

could you check this out and confirm the fix @michaelryancaputo?

@codecov
Copy link

codecov bot commented May 5, 2018

Codecov Report

Merging #175 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   99.71%   99.71%           
=======================================
  Files           1        1           
  Lines         346      346           
  Branches       51       51           
=======================================
  Hits          345      345           
  Misses          1        1
Impacted Files Coverage Δ
index.js 99.71% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa0efcc...2a4bfd8. Read the comment docs.

@quantizor quantizor merged commit 0ab6780 into master May 6, 2018
@quantizor quantizor deleted the fix-html-example branch May 6, 2018 16:25
@stephtr
Copy link

stephtr commented May 8, 2018

Thanks, it is definitely better than before. The issue itself isn't fully fixed, <div><div class="test"></div></div> (where the inner element has an attribute) gets visually rendered as "</div>".

@quantizor
Copy link
Owner Author

@stephtr good point, I'll add it in the next patch release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendering HTML Tables with nested lists parses incorrectly
2 participants