Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests and QuarkusCxfProcessor #499

Merged
merged 13 commits into from
Aug 19, 2022

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Aug 18, 2022

No description provided.

ppalaga added 10 commits August 18, 2022 16:05
and also in native mode

* Put Woodstox stuff into a separate module so that Camel Quarkus can
reuse it
* Put jakarta.xml.ws related build steps into a separate WsApiProcessor
so that there is some structure in the processors
…entations already available in io.quarkiverse.cxf.deployment.WsApiProcessor.registerForReflection()
…stead of abstract classes, fix related issues
ppalaga and others added 3 commits August 18, 2022 17:53
Bumps [woodstox-core](https://github.com/FasterXML/woodstox) from 6.2.7 to 6.3.1.
- [Release notes](https://github.com/FasterXML/woodstox/releases)
- [Commits](FasterXML/woodstox@woodstox-core-6.2.7...woodstox-core-6.3.1)

---
updated-dependencies:
- dependency-name: com.fasterxml.woodstox:woodstox-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 18, 2022

Would anybody like to review?

@shumonsharif
Copy link
Contributor

I can review in a couple hours.

Copy link
Contributor

@shumonsharif shumonsharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ppalaga ... one minor comment is that CXF 3.5.3 depends on woodstox-core 6.2.8. I'm not sure if switching that to 6.3.1 may have any unintended side effects?

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 19, 2022

LGTM @ppalaga ... one minor comment is that CXF 3.5.3 depends on woodstox-core 6.2.8. I'm not sure if switching that to 6.3.1 may have any unintended side effects?

Woodstox folks care for their backwards compatibility. Citing from their release page

Woodstox follows Apache versioning convention, and similar to Semantic Versioning from external user perspective.

So going to a newer minor should not be a problem. Also, if our tests pass it should be fine.
We can revert or report an issue to them if there are issues we do not see now.

@ppalaga ppalaga merged commit 6082a85 into quarkiverse:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants