Fix #185 make the jrxml path absolute #190
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
approved these changes
Mar 5, 2025
|
Build running now! |
bulldog98
force-pushed
the
bugfix/problem-with-gradle-jrxml-path
branch
from
44e2d3d to
814b042
Compare
|
ahhh its failing the formatter! |
bulldog98
force-pushed
the
bugfix/problem-with-gradle-jrxml-path
branch
from
814b042 to
cdf1a5f
Compare
|
formatted it now. |
nderwin
reviewed
Mar 5, 2025
| import java.io.FileOutputStream; | ||
| import java.io.IOException; | ||
| import java.io.InputStream; | ||
| import java.io.*; |
There was a problem hiding this comment.
Can these be re-expanded, please?
There was a problem hiding this comment.
That part was autoformatted by my Ide.
There was a problem hiding this comment.
I'll update the PR, after I see the builds pass.
There was a problem hiding this comment.
@bulldog98 if Ubuntu passes you are good. Its MacOS that takes forever so if Ubuntu passes its good enough not to wait.
|
Re-running |
bulldog98
force-pushed
the
bugfix/problem-with-gradle-jrxml-path
branch
from
cdf1a5f to
289fb88
Compare
|
@all-contributors add @bulldog98 for code |
|
I've put up a pull request to add @bulldog98! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #185