fix: make proxy a runnable jar from maven #125
Conversation
maxandersen
commented
Feb 25, 2025
maxandersen
commented
- make the released proxy jar directly runnable
- remove unneeded --quiet
- document runnable jar coordinates (works when this is released)
devtools/stdio-sse-proxy/src/main/java/io/quarkiverse/mcp/server/proxy/StdioSseProxy.java
Outdated
Show resolved
Hide resolved
|
|
||
| ```shell script | ||
| jbang io.quarkiverse.mcp:quarkus-mcp-stdio-sse-proxy:RELEASE -h |
There was a problem hiding this comment.
What does the :RELEASE stand for? Is it handled specifically by JBang?
There was a problem hiding this comment.
standard maven coordinate syntax for getting latest released version (non-snapshot)
There was a problem hiding this comment.
Is it? I've never heard about it. I mean, io.quarkiverse.mcp:quarkus-mcp-stdio-sse-proxy:RELEASE is not a valid Maven artifact coordinate (at least according to chatgpt and https://maven.apache.org/guides/mini/guide-naming-conventions.html). release is a valid qualifier but nothing more. But maybe I'm missing something?
There was a problem hiding this comment.
Its been around since Maven 2 - see https://stackoverflow.com/questions/30571/how-do-i-tell-maven-to-use-the-latest-version-of-a-dependency/1172371#1172371
it is not jbang doing any interpretation here - its maven resolver and you can use <version>RELEASE</version> in your pom.xml dependencies (but not for plugins).
There was a problem hiding this comment.
I see. The RELEASE and LATEST markers seem to be a deprecated legacy feature from Maven 2 ;-). At least, I wasn't able to find any official docs, except for https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=2852668#Maven3.xCompatibilityNotes-PluginMetaversionResolution.
There was a problem hiding this comment.
That is for plugins it was explicitly removed as makes builds irreproducible. still possible for resolver because it is useful - like in cases like this.
its like docker pull xyz:latest or sdk install quarkus where you just get the latest.
mkouba
force-pushed
the
proxyasrelease
branch
from
81e00eb to
4a8e7ae
Compare
