Pull request 487 fix #491
Merged
Pull request 487 fix #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hbelmiro I wasn’t sure if I should wait for @ricardozanini first, so just to avoid any misunderstanding, I created the PR. Please let me know if there's something else I can help with. |
|
Sh*t, I was wondering why I got conflicts and I just realized, I didn't create the PR from |
hbelmiro
approved these changes
Sep 19, 2023
|
@patr1kt0th It's not a problem if it's effectively changing what it should change. But if you want to fix it anyway, you can just rebase your branch. |
ricardozanini
approved these changes
Sep 22, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Sep 22, 2023
* Add @PartFilename config - on/off, value, value suffix * Split PartFilenameTest into classic and reactive * Get rid of code duplicity in tests, fix README.md * Revert messed up README.md formatting * Remove problematic dependencies, add testExcludes for Classic/Reactive tests
hbelmiro
pushed a commit
that referenced
this pull request
Sep 22, 2023
* Add @PartFilename config - on/off, value, value suffix * Split PartFilenameTest into classic and reactive * Get rid of code duplicity in tests, fix README.md * Revert messed up README.md formatting * Remove problematic dependencies, add testExcludes for Classic/Reactive tests Co-authored-by: Patrik Toth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #487