Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug [Bean Validation]: Compilation error with array of strings with validations #926

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

joschi
Copy link
Contributor

@joschi joschi commented Dec 23, 2024

Fixes #925

@joschi joschi requested a review from a team as a code owner December 23, 2024 15:43
@ricardozanini
Copy link
Member

Hi! Thank you for reporting this bug. Do you plan to append this PR with the fix?

@joschi
Copy link
Contributor Author

joschi commented Dec 23, 2024

Do you plan to append this PR with the fix?

That depends a bit on my availability in the next few weeks, but definitely not this year anymore. 😅

If you're already in the code base and don't have to learn about it, I'd appreciate somebody else fixing this bug.

Didn't plan to, but added a fix.

@joschi joschi force-pushed the bean-validation-missing-import branch from 1c165d7 to 74efde2 Compare January 31, 2025 12:55
@joschi
Copy link
Contributor Author

joschi commented Jan 31, 2025

@ricardozanini I've added the missing imports to the respective template. Could you please re-run the workflows?

@hbelmiro
Copy link
Contributor

hbelmiro commented Feb 1, 2025

@joschi I'm not following. Is it supposed to be reviewed or it's just a bug report? If the latter, can you revert it to draft and add a DO NOT MERGE to the title?

@joschi
Copy link
Contributor Author

joschi commented Feb 1, 2025

@hbelmiro It's a bug reproducer with a fix added one month later. 😉

@ricardozanini

This comment was marked as outdated.

@ricardozanini
Copy link
Member

@denvitaharen @joschi I'll merge this one and close #975. Can we come to an agreement since two PRs are fixing the same issue?

@joschi joschi force-pushed the bean-validation-missing-import branch from 74efde2 to 130a728 Compare February 19, 2025 07:20
@denvitaharen
Copy link
Contributor

@denvitaharen @joschi I'll merge this one and close #975. Can we come to an agreement since two PRs are fixing the same issue?

Good with me! :)

@ricardozanini ricardozanini merged commit 80a4766 into quarkiverse:main Feb 19, 2025
7 checks passed
@ricardozanini
Copy link
Member

@all-contributors please add @joschi for code

Copy link
Contributor

@ricardozanini

I've put up a pull request to add @joschi! 🎉

github-actions bot pushed a commit that referenced this pull request Feb 19, 2025
…alidations (#926)

* bug: bean validation missing import with array and mandatory items

* fix: add Jakarta Bean validation imports to model.qute
hbelmiro pushed a commit that referenced this pull request Feb 19, 2025
…alidations (#926) (#1004)

* bug: bean validation missing import with array and mandatory items

* fix: add Jakarta Bean validation imports to model.qute

Co-authored-by: Jochen Schalanda <[email protected]>
@joschi joschi deleted the bean-validation-missing-import branch February 19, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug [Bean Validation]: Compilation error with array of strings with validations
5 participants