Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid importing quarkus-artemis-bom in the project parent #181

Closed
jamesnetherton opened this issue Nov 21, 2023 · 1 comment · Fixed by #182
Closed

Avoid importing quarkus-artemis-bom in the project parent #181

jamesnetherton opened this issue Nov 21, 2023 · 1 comment · Fixed by #182

Comments

@jamesnetherton
Copy link

Unless I'm mistaken, only the artemis-jms integration test module needs to use anything from quarkus-artemis-bom. Therefore, it might be better if the BOM import was done directly in the test module and not in the project parent.
@zhfeng
Copy link
Contributor

zhfeng commented Nov 21, 2023

Thanks for reporting! and yeah, it should be moved to test module.

zhfeng added a commit to zhfeng/quarkus-pooled-jms that referenced this issue Nov 21, 2023
@zhfeng
Fix quarkiverse#181 to move quarkus-artemis-bom to test module
cc7dfe3
@zhfeng zhfeng linked a pull request Nov 21, 2023 that will close this issue
Fix #181 to move quarkus-artemis-bom to test module #182
Merged
zhfeng added a commit that referenced this issue Nov 21, 2023
@zhfeng
Fix #181 to move quarkus-artemis-bom to test module (#182)
d6d4426
zhfeng added a commit that referenced this issue Nov 21, 2023
@zhfeng
Fix #181 to move quarkus-artemis-bom to test module
58210be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #181 to move quarkus-artemis-bom to test module zhfeng/quarkus-pooled-jms
2 participants
@zhfeng @jamesnetherton