Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat x.y.999-SNAPSHOT as snapshot version #924

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

rsvoboda
Copy link
Member

Summary

Treat x.y.999-SNAPSHOT as snapshot version

Port of one change from #920
To cover cases like 3.2.999-SNAPSHOT and whatever future 3.y.999-SNAPSHOT

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member

I will temporarily add DON'T MERGE label for I need #928 to be based on the latest main, otherwise release workflow breaks.

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I was asked, but I approve :-)

Personally I'd use endsWith for it only iterate over (the worst case) word.length() while contains goes from start of the tested string (so it can't leverage offset). But it doesn't really matter. Maybe you want to match some other 999-SNAPSHOT versions with suffix too?

@michalvavrik michalvavrik merged commit f5d51b5 into quarkus-qe:main Oct 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants