Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop duplicated definition of quarkus-opentelemetry #1005

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Drop duplicated definition of quarkus-opentelemetry #1005

merged 1 commit into from
Jan 19, 2023

Conversation

rsvoboda
Copy link
Member

Drop duplicated definition of quarkus-opentelemetry

ATM one gets following warning in console:

 Warning:  Some problems were encountered while building the effective model for io.quarkus.ts.qe:vertx-web-client:jar:1.0.0-SNAPSHOT
Warning:  'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: io.quarkus:quarkus-opentelemetry:jar -> duplicate declaration of version (?) @ line 18, column 21
  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@rsvoboda rsvoboda requested a review from mjurc January 19, 2023 09:46
@rsvoboda rsvoboda added the triage/backport-2.13? It needs to backport changes to branch 2.13 label Jan 19, 2023
@rsvoboda
Copy link
Member Author

Marking for backport as https://github.com/quarkus-qe/quarkus-test-suite/blob/2.13/http/vertx-web-client/pom.xml has the same issue.

mjurc
mjurc approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@mjurc mjurc merged commit 14bfc84 into quarkus-qe:main Jan 19, 2023
@pjgg pjgg mentioned this pull request Jan 30, 2023
Merged
1 task
@pjgg pjgg added this to the 2.7 milestone Feb 2, 2023
@pjgg pjgg removed the triage/backport-2.13? It needs to backport changes to branch 2.13 label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjurc mjurc mjurc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@rsvoboda @mjurc @pjgg