-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check, that dev-mode is omitted on projects with pom packaging #1009
Conversation
quarkus-cli/src/test/java/io/quarkus/ts/quarkus/cli/QuarkusCliCreateJvmApplicationIT.java
Outdated
Show resolved
Hide resolved
quarkus-cli/src/test/java/io/quarkus/ts/quarkus/cli/QuarkusCliCreateJvmApplicationIT.java
Outdated
Show resolved
Hide resolved
quarkus-cli/src/test/java/io/quarkus/ts/quarkus/cli/QuarkusCliCreateJvmApplicationIT.java
Outdated
Show resolved
Hide resolved
{//set packaging to POM | ||
Path pom = getFileFromApplication(app, ROOT_FOLDER, "pom.xml").toPath(); | ||
System.out.println(pom); | ||
List<String> content = Files.readAllLines(pom); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And what about to use this maven lib:
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-model</artifactId>
<scope>test</scope>
</dependency>
And then parser / change the pom with something like
File pom = getFileFromApplication(app, ROOT_FOLDER, "pom.xml");
MavenXpp3Reader reader = new MavenXpp3Reader();
Model model = reader.read(new FileReader(pom));
model.setPackaging("pom");
MavenXpp3Writer mavenWriter = new MavenXpp3Writer();
Writer writer = new FileWriter(pom.getPath());
mavenWriter.write(writer, model);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not need such advanced modifications. Read+replace is enough
f329ba8
to
32af77b
Compare
Required for QUARKUS-2757
32af77b
to
4fd38c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Check, that dev-mode is omitted on projects with pom packaging
Required for QUARKUS-2757
Please select the relevant options.
run tests
phrase in comment)Checklist: