Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable blocking CLI special character test #1013

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Disable blocking CLI special character test #1013

merged 1 commit into from
Jan 23, 2023
+2 −0

Conversation

mjurc
Copy link
Member

@mjurc mjurc commented Jan 23, 2023

Summary

  • Disabling QuarkusCliSpecialCharsIT#shouldCreateApplicationOnJvmWithSpaces until a fix that would make it fail rather than block the session indefinitely is implemented as to not block CI runs.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@mjurc
Disable blocking CLI special character test
4c20ea7 
* Disabling
  QuarkusCliSpecialCharsIT#shouldCreateApplicationOnJvmWithSpaces until
  a fix that would make it fail rather than block the session
  indefinitely is implemented as to not block CI runs.
@mjurc mjurc requested a review from fedinskiy January 23, 2023 09:22
fedinskiy
fedinskiy approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@fedinskiy fedinskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But let's wait for CI

@ghost
Copy link

ghost commented Jan 23, 2023

run tests

@michalvavrik
Copy link
Member

hey, "run tests" above was just my POC, please ignore it, thx

@ghost
Copy link

ghost commented Jan 23, 2023

run tests

2 similar comments
@ghost
Copy link

ghost commented Jan 23, 2023

run tests

@michalvavrik
Copy link
Member

run tests

@mjurc mjurc merged commit b8a56a0 into quarkus-qe:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedinskiy fedinskiy fedinskiy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjurc @michalvavrik @fedinskiy