Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of QUARKUS-2748 #1014

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Refactoring of QUARKUS-2748 #1014

merged 1 commit into from
Jan 25, 2023

Conversation

fedinskiy
Copy link
Contributor

Summary

adding http test and improving error messages

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy fedinskiy requested a review from pjgg January 23, 2023 14:00
@fedinskiy fedinskiy added the triage/backport-2.13? It needs to backport changes to branch 2.13 label Jan 23, 2023
@fedinskiy fedinskiy force-pushed the feature/https-devui-improved branch from d4f52c8 to 6563431 Compare January 25, 2023 08:08
pjgg
pjgg approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@pjgg pjgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lest wait to CI

@fedinskiy fedinskiy merged commit 58519ac into quarkus-qe:main Jan 25, 2023
@pjgg pjgg mentioned this pull request Jan 30, 2023
Merged
1 task
@pjgg pjgg added this to the 2.7 milestone Feb 2, 2023
@pjgg pjgg removed the triage/backport-2.13? It needs to backport changes to branch 2.13 label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjgg pjgg pjgg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
2 participants
@fedinskiy @pjgg