Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction-API scenario / Classic flavor #1017

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

pjgg
Copy link
Contributor

@pjgg pjgg commented Jan 24, 2023

Summary

Jira Ref: https://issues.redhat.com/browse/QUARKUS-2492

Add Quarkus transaction programmatic API scenario / Classic flavor

  • Programmatic API transaction
  • Lambda API transaction
  • Rollback

Covered databases: Oracle, Mysql, Mssql, MariaDB and postresql
SmokeTest over: openAPI, tracing and metrics

Please select the relevant options.

  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@pjgg pjgg marked this pull request as draft January 24, 2023 18:22
@pjgg pjgg force-pushed the QUARKUS-2492 branch 3 times, most recently from 246e10a to cb9716a Compare January 25, 2023 15:10
@pjgg pjgg requested a review from fedinskiy January 25, 2023 15:11
@pjgg pjgg changed the title (DRAFT) Add transaction-API scenario Add transaction-API scenario / Classic flavor Jan 25, 2023
@pjgg pjgg marked this pull request as ready for review January 25, 2023 15:18
@pjgg
Copy link
Contributor Author

pjgg commented Jan 25, 2023

run tests

@pjgg pjgg added the triage/backport-2.13? It needs to backport changes to branch 2.13 label Jan 25, 2023
@fedinskiy
Copy link
Contributor

And one more thing: it was missed during test plans phase, but could you consider adding our "full picture" topics (logging/tracing/metrics/security and openapi)? I presume, that at least metrics and security can be of interest in that case.

@pjgg pjgg force-pushed the QUARKUS-2492 branch 3 times, most recently from b4b3345 to 8cdd481 Compare January 26, 2023 18:12
@pjgg pjgg requested a review from fedinskiy January 26, 2023 18:27
@pjgg
Copy link
Contributor Author

pjgg commented Jan 26, 2023

And one more thing: it was missed during test plans phase, but could you consider adding our "full picture" topics (logging/tracing/metrics/security and openapi)? I presume, that at least metrics and security can be of interest in that case.

There are no integration surfaces between narayana+security, narayana+micrometer or narayana+openAPI
that security is handled either by persistence or endpoints and there are absolutely no metrics provided by narayana extension, that all the gauges have to be manual.

@pjgg pjgg requested a review from fedinskiy January 27, 2023 15:06
@pjgg pjgg requested a review from fedinskiy January 27, 2023 16:38
@pjgg
Copy link
Contributor Author

pjgg commented Jan 27, 2023

run tests

@pjgg
Copy link
Contributor Author

pjgg commented Jan 29, 2023

OCP IT test:
JVM mode: Quarkus QE TS: SQL Database: Narayana-transactions . SUCCESS [06:33 min]
Native Mode: [INFO] Quarkus QE TS: SQL Database: Narayana-transactions . SUCCESS [24:44 min]

@fedinskiy
Copy link
Contributor

CI failures are not in database modules and therefore, probably, unrelated

@fedinskiy fedinskiy merged commit 6f3a20a into quarkus-qe:main Jan 30, 2023
@pjgg pjgg added this to the 2.7 milestone Feb 2, 2023
@pjgg pjgg removed the triage/backport-2.13? It needs to backport changes to branch 2.13 label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants