-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable tests with Quarkus OpenShift extension as upstream issue is fixed #1106
Enable tests with Quarkus OpenShift extension as upstream issue is fixed #1106
Conversation
run tests |
d8c55ae
to
a434bbb
Compare
run tests |
a434bbb
to
c236ec5
Compare
run tests |
c236ec5
to
bfd76bf
Compare
run tests |
@michalvavrik what are your plans with this PR? |
@rsvoboda problem is that all tests I tried locally (in OC are green), I think there are some params that CI is using that I didn't. I'll proceed on this today, but I have a lot of work on daily failures. |
bfd76bf
to
e345cda
Compare
run tests |
e345cda
to
574cc62
Compare
run tests |
Opened quarkusio/quarkus#32193, also CI was adjusted which fixed some of issues. |
574cc62
to
a3087f0
Compare
run tests |
a3087f0
to
527f757
Compare
run tests |
527f757
to
1155289
Compare
run tests |
1155289
to
d9f0b68
Compare
run tests |
d9f0b68
to
473fed6
Compare
run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Summary
OperatorOpenShiftInfinispanCountersIT
as it sometimes expects 200 status and receives 503, flaky method changes, so I disabled whole classquay.io/quarkus/ubi-quarkus-native-s2i
is obsolete and we need to useubi-quarkus-graalvmce-s2i
- Quarkus S2I native binary can't be used with OpenShift build configuration quarkusio/quarkus#30829 (comment) I think I changed it as part of debugging, not sure if everything works correctly without this change, but we need to change it anywayI'll investigate disabled tests next week, but this PR is already WIP for quite long time, let's get it in.
Please select the relevant options.
run tests
phrase in comment)Checklist: