Fix daily build by disabling Pact tests due to upstream issue, disabling Microprofile OpenTracing module that does work after deps renaming and rename extensions #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalvavrik
force-pushed
the
feature/disable-pact
branch
from
a0a6c67 to
a05fc9a
Compare
michalvavrik
force-pushed
the
feature/disable-pact
branch
from
a05fc9a to
fe8aa64
Compare
michalvavrik
changed the title
michalvavrik
changed the title
michalvavrik
changed the title
michalvavrik
force-pushed
the
feature/disable-pact
branch
2 times, most recently
from
28f5f68 to
68e1e8c
Compare
michalvavrik
force-pushed
the
feature/disable-pact
branch
from
68e1e8c to
93f1308
Compare
|
I think CLI failures are expected because listed extensions still list |
9 tasks
|
I could probably postpone CLI changes till upstream is released, but it feels like something that is happening in next days and change is clear. I'll leave it on you. |
|
CR1 release happened yesterday -quarkus-release/release#50 Full platform release is in 2 weeks. That's when registry, CLI version, etc. get updated. |
|
@rsvoboda I don't really have a strong opinion either way |
|
Alright, disable it is. |
michalvavrik
force-pushed
the
feature/disable-pact
branch
from
0c314ee to
e38d4f2
Compare
|
Awaiting approvals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes daily build and PRs CI by:
quarkus-resteasy-reactive-spi-deploymentrelocations doesn't seem to fix this, possibly because the OpenTracing wasn't build with new relocations?Reflect changes in Quarkus reactive extension names as had already been done in the quarkus-qe/beefy-scenarios#464:
Our own modules are not renamed as that would make backports hard and first and foremost, we need daily build green.
Please select the relevant options.
run testsphrase in comment)Checklist: