Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added isRHBQ method to check if the version contains string redhat #1991

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

TimonCzech
Copy link

Summary

Replaced QuarkusProperties.getVersion().contains("redhat") usage with QuarkusProperties.isRHBQ()

quarkus-qe/quarkus-test-framework#1294
Waiting for merge

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97 jedla97 self-requested a review September 9, 2024 15:29
@jedla97
Copy link
Member

jedla97 commented Sep 9, 2024

This PR is waiting for FW release

Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimonCzech Thanks for updating this! I have just one comment otherwise it's look good to me.

Also please rebase this as the new framework containing your changes was merged! So now it should work

@TimonCzech TimonCzech marked this pull request as ready for review September 12, 2024 07:19
@github-actions github-actions bot added the triage/flaky-test Signal that flaky tests were detected during CI run label Sep 12, 2024
Copy link

Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version'

@jedla97
Copy link
Member

jedla97 commented Sep 12, 2024

Flaky test io.quarkus.ts.messaging.kafka.reactive.streams.KafkaGratefulShutdownIT.testConnection

Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for update and rebase. Now it's look good to me.

@jedla97 jedla97 merged commit 547f3d3 into quarkus-qe:main Sep 12, 2024
8 checks passed
@michalvavrik michalvavrik removed the triage/flaky-test Signal that flaky tests were detected during CI run label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants